Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os: TestFileChdir fail when GOROOT is a symbolic link #64281

Closed
qiulaidongfeng opened this issue Nov 20, 2023 · 1 comment
Closed

os: TestFileChdir fail when GOROOT is a symbolic link #64281

qiulaidongfeng opened this issue Nov 20, 2023 · 1 comment
Labels
NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone

Comments

@qiulaidongfeng
Copy link
Contributor

qiulaidongfeng commented Nov 20, 2023

What version of Go are you using (go version)?

$ go version
go version devel go1.22-631a6c2a Fri Nov 17 23:34:11 2023 +0000 windows/amd64

Does this issue reproduce with the latest release?

yes.

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
set GO111MODULE=auto
set GOARCH=amd64
set GOBIN=
set GOCACHE=D:\tmp\go-build
set GOENV=C:\Users\26454\AppData\Roaming\go\env
set GOEXE=.exe
set GOEXPERIMENT=
set GOFLAGS=
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOINSECURE=
set GOMODCACHE=D:\file\gofile\pkg\mod
set GONOPROXY=
set GONOSUMDB=
set GOOS=windows
set GOPATH=D:\file\gofile
set GOPRIVATE=
set GOPROXY=https://goproxy.cn,direct
set GOROOT=C:\Users\26454\.go\current
set GOSUMDB=sum.golang.org
set GOTMPDIR=
set GOTOOLCHAIN=local
set GOTOOLDIR=C:\Users\26454\.go\current\pkg\tool\windows_amd64
set GOVCS=
set GOVERSION=devel go1.22-631a6c2a Fri Nov 17 23:34:11 2023 +0000
set GCCGO=gccgo
set GOAMD64=v3
set AR=ar
set CC=gcc
set CXX=g++
set CGO_ENABLED=0
set GOMOD=
set GOWORK=
set CGO_CFLAGS=-O2 -g
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-O2 -g
set CGO_FFLAGS=-O2 -g
set CGO_LDFLAGS=-O2 -g
set PKG_CONFIG=pkg-config
set GOGCCFLAGS=-m64 -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=C:\Users\26454\AppData\Local\Temp\go-build2761128909=/tmp/go-build -gno-record-gcc-switches

What did you do?

GOROOT is a symbolic link.

go tool dist test -run=os

What did you expect to see?

test pass.

What did you see instead?

--- FAIL: TestFileChdir (0.00s)
os_test.go:1624: fd.Chdir failed, got D:\go\gotip\src\os, want C:\Users\26454.go\current\src\os
FAIL
FAIL os 10.859s
FAIL

@gopherbot
Copy link

Change https://go.dev/cl/540521 mentions this issue: os: avoid TestFileChdir fail when GOROOT is a symbolic link

@mknyszek mknyszek added this to the Backlog milestone Nov 20, 2023
@mknyszek mknyszek added the NeedsFix The path to resolution is known, but the work has not been done. label Nov 20, 2023
@dmitshur dmitshur modified the milestones: Backlog, Go1.22 Nov 21, 2023
@dmitshur dmitshur added the Testing An issue that has been verified to require only test changes, not just a test failure. label Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants