Note there is some logic to write a "return" snippet with zero values here. This proposed completion could work in a similar way to that linked completion.

Thanks @muirdm that is a great point!

This proposal would be a subset of that functionality. I'll see if I can make it fit together nicely.

Thanks @vikblom and @muirdm!

I have tentatively put this in the gopls@v0.16.0 milestone, just for our own tracking purposes. You are course free to do as little or as much as you want, whenever you want :)

Change https://go.dev/cl/546775 mentions this issue: gopls/internal/lsp/source/completion: complete return snippet

This was fixed by https://go.dev/cl/546775

(the commit message said "Closes" instead of "Fixes").

Hi, I'm sorry for commenting so late. If "err" exists, should it be used first to instead "nil"? I think this is more common.

Hi @rogeryk

That is a valid point. I decided against it, keeping the zero value even for the error, to keep the implementation simple.

The end user might want err, fmt.Errorf, errors.New, or some local variant thereof (which is what I almost always use). My reasoning was that since the placeholder almost surely needs to be replaced anyway, it doesn't hurt that it is nil.