all: go tool dist test -asan fails many tests
#64257
Labels
compiler/runtime
Issues related to the Go compiler and/or runtime.
help wanted
NeedsInvestigation
Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Comments
qiulaidongfeng
changed the title
mauri870
changed the title
mauri870
added
NeedsInvestigation
|
cc @golang/wsl |
|
(CC @golang/windows) |
|
This turns out not to be specific to WSL2: this also fails on Linux. |
bcmills
changed the title
go tool dist test -asan fails many tests
|
On |
|
Allocs-related tests fail because when |
|
For the bug in the assembly function, I will submit a patch to fix it. As for the issue of allocs tests, we may need to skip these tests when -asan is on. Does anyone have any other ideas? Thank you. |
|
Change https://go.dev/cl/543837 mentions this issue: |
|
gopherbot
pushed a commit
that referenced
this issue
Nov 22, 2023
Variables in functions implemented in assembly should have the same names as when they were defined. The names of some variables in asan-related assembly functions do not follow the above rule, which will cause the runtime test to fail. This CL fixes this issue. Updates #64257 Change-Id: I261f4db807d25e460513ef1c92cd1b707cdd1a16 Reviewed-on: https://go-review.googlesource.com/c/go/+/543837 Run-TryBot: Fannie Zhang <Fannie.Zhang@arm.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Cherry Mui <cherryyz@google.com> Reviewed-by: Bryan Mills <bcmills@google.com>
This is a good one! |
@bcmills When I was about to write the fixing code, I found that this idea was not very good. Because when we use Perhaps we may need to create a new SkipIfOptimizationOff-like function for asan, called SkipAsanOn or something else. What do you think? Thank you. |
|
@zhangfannie, I think it would be fine to spuriously skip alloc tests on the If real users care about reducing allocations, presumably they should build their programs in a way that does not explicitly prevent the compiler from reducing allocations. 😅 |
|
@bcmills Perhaps we could create an exported function called |
|
@zhangfannie Looks like you reached the same dead end as me, in #64256. I ended up filling #64611 which I believe is a good addition that would make it much easier to deal with these test allocation cases moving forward. I would be glad to hear your opinions on this. cc @bcmills |
I think this is a good approach. Thank you for doing this. |
|
I got back to working on this after the There are many tests that fail with wrong allocation counts, and these can now be skipped by checking asan.Enabled. I'm attaching the output of tests that are still failing. I'm not sure if they are false positives and should be skipped as well. There is a AddressSanitizer stack-overflow in runtime, failures in pprof tests and test10303 in src/cmd/cgo/internal/test. Sending as an attachment because Firefox crashes if I try to paste the contents |
Test fail of cmd/internal/moddeps maybe a false alarm? I can't reproduce it in wsl2. |
Sorry, please ignore the dep tests, my go tree is dirty. The ones that I'm worried about are cgo, runtime and pprof. |
|
My machine（wsl2） output runtime cgo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
and others
What version of Go are you using (
go version)?Does this issue reproduce with the latest release?
yes.
What operating system and processor architecture are you using (
go env)?go envOutputWhat did you do?
go tool dist test -asan
What did you expect to see?
test pass.
What did you see instead?
output.txt
The text was updated successfully, but these errors were encountered: