Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: SignatureHelp bug reported by telemetry #64245

Closed
adonovan opened this issue Nov 17, 2023 · 3 comments
Closed

x/tools/gopls: SignatureHelp bug reported by telemetry #64245

adonovan opened this issue Nov 17, 2023 · 3 comments
Labels
gopls/telemetry-wins gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.15.0

Comments

@adonovan
Copy link
Member

adonovan commented Nov 17, 2023 •
edited

This stack S-zlGg, _mSPWg was reported by telemetry:

SignatureHelp:72 is

return nil, 0, bug.Errorf("call to unexpected built-in %v (%T)", obj, obj)

gopls/bug
golang.org/x/tools/gopls/internal/bug.report:35
golang.org/x/tools/gopls/internal/bug.Errorf:2
golang.org/x/tools/gopls/internal/lsp/source.SignatureHelp:72
golang.org/x/tools/gopls/internal/lsp.(*Server).signatureHelp:9
golang.org/x/tools/gopls/internal/lsp.(*Server).SignatureHelp:1
golang.org/x/tools/gopls/internal/lsp/protocol.serverDispatch:490
golang.org/x/tools/gopls/internal/lsp/protocol.ServerHandler.func1:5
golang.org/x/tools/gopls/internal/lsp/lsprpc.handshaker.func1:52
golang.org/x/tools/internal/jsonrpc2.MustReplyHandler.func1:2
golang.org/x/tools/internal/jsonrpc2.AsyncHandler.func1.2:3
runtime.goexit:0

golang.org/x/tools/gopls@v0.14.1 go1.19.1 darwin/amd64 (1)

Reported using golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.
@adonovan adonovan mentioned this issue Nov 17, 2023
Closed
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Nov 17, 2023
@gopherbot gopherbot added this to the Unreleased milestone Nov 17, 2023
@adonovan adonovan changed the title x/tools/gopls: SignatureHelp bug reported by telemetry [S-zlGg] x/tools/gopls: SignatureHelp bug reported by telemetry Nov 17, 2023
@adonovan adonovan added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Nov 17, 2023
@findleyr findleyr modified the milestones: Unreleased, gopls/v0.15.0 Nov 17, 2023
@adonovan
Copy link
Member Author

Dup of #63804, already fixed.

@findleyr findleyr closed this as not planned Won't fix, can't repro, duplicate, stale Dec 11, 2023
@adonovan
Copy link
Member Author

How can a closed (fixed) issue be closed again as not planned? That's confusing.

@findleyr
Copy link
Contributor

Oh, I'm just going through marking dupes as "not planned" instead of "completed", for tracking purposes.

Are you just commenting on how Github reports this state change? I agree it is confusing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gopls/telemetry-wins gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.15.0
Development

No branches or pull requests
3 participants
@adonovan @gopherbot @findleyr