Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: Analyze bug reported by telemetry #64238

Closed
adonovan opened this issue Nov 17, 2023 · 2 comments
Closed

x/tools/gopls: Analyze bug reported by telemetry #64238

adonovan opened this issue Nov 17, 2023 · 2 comments
Labels
gopls/telemetry-wins gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@adonovan
Copy link
Member

adonovan commented Nov 17, 2023

This stack mmNRcw was reported by telemetry:

Analyze.266 is

				// Although this 'skip' operation is logically sound,
				// it is nonetheless surprising that its absence should
				// cause #60909 since none of the analyzers added for
				// requirements (e.g. ctrlflow, inspect, buildssa)
				// is capable of reporting diagnostics.
				if summary := root.summary.Actions[a.Name]; summary != nil {
					if n := len(summary.Diagnostics); n > 0 {
						bug.Reportf("Internal error: got %d unexpected diagnostics from analyzer %s. This analyzer was added only to fulfil the requirements of the requested set of analyzers, and it is not expected that such analyzers report diagnostics. Please report this in issue #60909.", n, a)
					}
				}

gopls/bug
golang.org/x/tools/gopls/internal/bug.report:35
golang.org/x/tools/gopls/internal/bug.Reportf:1
golang.org/x/tools/gopls/internal/lsp/cache.(*snapshot).Analyze:266
golang.org/x/tools/gopls/internal/lsp/source.Analyze:21
golang.org/x/tools/gopls/internal/lsp.(*Server).diagnosePkgs.func2:2
runtime.goexit:0
golang.org/x/tools/gopls@v0.14.1 go1.21.3 darwin/arm64 (4)
golang.org/x/tools/gopls@v0.14.1 go1.21.0 linux/amd64 (2)
golang.org/x/tools/gopls@v0.14.1 go1.21.1 darwin/arm64 (11)

Reported using golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Nov 17, 2023
@gopherbot gopherbot added this to the Unreleased milestone Nov 17, 2023
@adonovan adonovan added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Nov 17, 2023
@adonovan adonovan changed the title x/tools/gopls: Analyze bug reported by telemetry [mmNRcw] x/tools/gopls: Analyze bug reported by telemetry Nov 17, 2023
@findleyr findleyr modified the milestones: Unreleased, gopls/v0.15.0 Nov 17, 2023
@findleyr findleyr modified the milestones: gopls/v0.15.0, gopls/v0.16.0 Feb 6, 2024
@adonovan
Copy link
Member Author

This has not been observed in v0.15. I wonder whether it was inadvertently fixed.

@adonovan
Copy link
Member Author

No reports in v0.15; presumed inadvertently fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gopls/telemetry-wins gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Development

No branches or pull requests

3 participants