x/tools/gopls: bug in analysis importer reported by telemetry #64236

adonovan · 2023-11-17T18:12:17Z

This stack sbGdaw, hz09pg, zhKNnQ was reported by telemetry:

cache.(*analysisNode)._import.func1:41 is

		pkg, err := gcimporter.IImportShallow(an.fset, getPackages, an.summary.Export, string(an.m.PkgPath), bug.Reportf)
		if err != nil {
			an.typesErr = bug.Errorf("%s: invalid export data: %v", an.m, err)
			an.types = nil
		} else if pkg != an.types {
			log.Fatalf("%s: inconsistent packages", an.m)
		}

gopls/bug
golang.org/x/tools/gopls/internal/bug.report:35
golang.org/x/tools/gopls/internal/bug.Errorf:2
golang.org/x/tools/gopls/internal/lsp/cache.(*analysisNode)._import.func1:41
sync.(*Once).doSlow:5
sync.(*Once).Do:?65
golang.org/x/tools/gopls/internal/lsp/cache.(*analysisNode)._import:1
golang.org/x/tools/gopls/internal/lsp/cache.(*analysisNode).typeCheck.func2:34
golang.org/x/tools/gopls/internal/lsp/cache.importerFunc.Import:0
go/types.(*Checker).importPackage:28
go/types.(*Checker).collectObjects.func1:13
go/types.(*Checker).walkDecl:9
go/types.(*Checker).walkDecls:?391
go/types.(*Checker).collectObjects:42
go/types.(*Checker).checkFiles:32
go/types.(*Checker).Files:?341
golang.org/x/tools/gopls/internal/lsp/cache.(*analysisNode).typeCheck:117

golang.org/x/tools/gopls@v0.14.1 go1.21.3 linux/amd64 (1)

Reported using golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

Dups: NpfwWw OeW1wA

Duplicates:

This stack WRBqTw was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/bug.report:35
golang.org/x/tools/gopls/internal/bug.Errorf:2
golang.org/x/tools/gopls/internal/lsp/cache.(*analysisNode)._import.func1:41
sync.(*Once).doSlow:5
sync.(*Once).Do:?65
golang.org/x/tools/gopls/internal/lsp/cache.(*analysisNode)._import:1
golang.org/x/tools/gopls/internal/lsp/cache.(*analysisNode).typeCheck.func2:34
golang.org/x/tools/gopls/internal/lsp/cache.importerFunc.Import:0
go/types.(*Checker).importPackage:28
go/types.(*Checker).collectObjects.func1:10
go/types.(*Checker).walkDecl:9
go/types.(*Checker).walkDecls:?383
go/types.(*Checker).collectObjects:42
go/types.(*Checker).checkFiles:18
go/types.(*Checker).Files:?307
golang.org/x/tools/gopls/internal/lsp/cache.(*analysisNode).typeCheck:117

golang.org/x/tools/gopls@v0.14.2 go1.19.13 darwin/arm64 (1)

This stack C7ZvyQ was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/bug.report:35
golang.org/x/tools/gopls/internal/bug.Errorf:2
golang.org/x/tools/gopls/internal/lsp/cache.(*analysisNode)._import.func1:41
sync.(*Once).doSlow:5
sync.(*Once).Do:?65
golang.org/x/tools/gopls/internal/lsp/cache.(*analysisNode)._import:1
golang.org/x/tools/gopls/internal/lsp/cache.(*analysisNode).typeCheck.func2:34
golang.org/x/tools/gopls/internal/lsp/cache.importerFunc.Import:0
go/types.(*Checker).importPackage:28
go/types.(*Checker).collectObjects.func1:13
go/types.(*Checker).walkDecl:9
go/types.(*Checker).walkDecls:?399
go/types.(*Checker).collectObjects:42
go/types.(*Checker).checkFiles:29
go/types.(*Checker).Files:?372
golang.org/x/tools/gopls/internal/lsp/cache.(*analysisNode).typeCheck:117

golang.org/x/tools/gopls@v0.14.2 go1.22rc2 darwin/arm64 other,vscode (1)

This stack 6jGwIA was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:35
golang.org/x/tools/gopls/internal/util/bug.Errorf:2
golang.org/x/tools/gopls/internal/cache.(*analysisNode)._import.func1:41
sync.(*Once).doSlow:5
sync.(*Once).Do:?65
golang.org/x/tools/gopls/internal/cache.(*analysisNode)._import:1
golang.org/x/tools/gopls/internal/cache.(*analysisNode).typeCheck.func2:34
golang.org/x/tools/gopls/internal/cache.importerFunc.Import:0
go/types.(*Checker).importPackage:28
go/types.(*Checker).collectObjects.func1:13
go/types.(*Checker).walkDecl:9
go/types.(*Checker).walkDecls:?399
go/types.(*Checker).collectObjects:42
go/types.(*Checker).checkFiles:29
go/types.(*Checker).Files:?372
golang.org/x/tools/gopls/internal/cache.(*analysisNode).typeCheck:118

golang.org/x/tools/gopls@v0.15.0-pre.2 go1.22rc2 linux/amd64 vscode (1)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

Dups: OeW1wA NpfwWw sNopDQ YUgxTQ g_3FdA qOlVPg sNopAA NpfwVg rcxYqw

The text was updated successfully, but these errors were encountered:

findleyr · 2024-02-06T20:27:30Z

We can live with this in v0.15.0. Let's move to v0.16.0

adonovan · 2024-02-27T15:17:29Z

This stack NpfwWw was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Errorf:+2
golang.org/x/tools/gopls/internal/cache.(*analysisNode)._import.func1:+41
sync.(*Once).doSlow:+5
sync.(*Once).Do:=65
golang.org/x/tools/gopls/internal/cache.(*analysisNode)._import:+1
golang.org/x/tools/gopls/internal/cache.(*analysisNode).typeCheck.func2:+34
golang.org/x/tools/gopls/internal/cache.importerFunc.Import:+0
go/types.(*Checker).importPackage:+28
go/types.(*Checker).collectObjects.func1:+13
go/types.(*Checker).walkDecl:+9
go/types.(*Checker).walkDecls:=399
go/types.(*Checker).collectObjects:+42
go/types.(*Checker).checkFiles:+29
go/types.(*Checker).Files:=372
golang.org/x/tools/gopls/internal/cache.(*analysisNode).typeCheck:+118

golang.org/x/tools/gopls@v0.15.0-pre.3 go1.22.0 darwin/arm64 vscode (2)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

adonovan · 2024-02-27T15:19:26Z

This stack OeW1wA was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/bug.report:35
golang.org/x/tools/gopls/internal/bug.Errorf:2
golang.org/x/tools/gopls/internal/lsp/cache.(*analysisNode)._import.func1:41
sync.(*Once).doSlow:5
sync.(*Once).Do:?65
golang.org/x/tools/gopls/internal/lsp/cache.(*analysisNode)._import:1
golang.org/x/tools/gopls/internal/lsp/cache.(*analysisNode).typeCheck.func2:34
golang.org/x/tools/gopls/internal/lsp/cache.importerFunc.Import:0
go/types.(*Checker).importPackage:28
go/types.(*Checker).collectObjects.func1:13
go/types.(*Checker).walkDecl:9
go/types.(*Checker).walkDecls:?399
go/types.(*Checker).collectObjects:42
go/types.(*Checker).checkFiles:36
go/types.(*Checker).Files:?355
golang.org/x/tools/gopls/internal/lsp/cache.(*analysisNode).typeCheck:117

golang.org/x/tools/gopls@v0.14.2 devel darwin/arm64 vscode (1)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

adonovan · 2024-03-09T22:59:41Z

This stack sNopDQ was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Errorf:+2
golang.org/x/tools/gopls/internal/cache.(*analysisNode)._import.func1:+41
sync.(*Once).doSlow:+5
sync.(*Once).Do:=65
golang.org/x/tools/gopls/internal/cache.(*analysisNode)._import:+1
golang.org/x/tools/gopls/internal/cache.(*analysisNode).typeCheck.func2:+34
golang.org/x/tools/gopls/internal/cache.importerFunc.Import:+0
go/types.(*Checker).importPackage:+28
go/types.(*Checker).collectObjects.func1:+13
go/types.(*Checker).walkDecl:+9
go/types.(*Checker).walkDecls:=391
go/types.(*Checker).collectObjects:+42
go/types.(*Checker).checkFiles:+32
go/types.(*Checker).Files:=341
golang.org/x/tools/gopls/internal/cache.(*analysisNode).typeCheck:+118

golang.org/x/tools/gopls@v0.15.1 go1.21.1 linux/amd64 vscode (1)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

adonovan · 2024-03-13T03:15:42Z

This stack YUgxTQ was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Errorf:+2
golang.org/x/tools/gopls/internal/cache.(*analysisNode)._import.func1:+41
sync.(*Once).doSlow:+5
sync.(*Once).Do:=65
golang.org/x/tools/gopls/internal/cache.(*analysisNode)._import:+1
golang.org/x/tools/gopls/internal/cache.(*analysisNode)._import.func1.1.1:+1
golang.org/x/sync/errgroup.(*Group).Go.func1:+3
runtime.goexit:+0

golang.org/x/tools/gopls@v0.15.1 go1.22.0 linux/amd64 vscode (1)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

adonovan · 2024-03-21T16:42:20Z

This stack g_3FdA was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Errorf:+2
golang.org/x/tools/gopls/internal/cache.(*analysisNode)._import.func1:+41
sync.(*Once).doSlow:+5
sync.(*Once).Do:=65
golang.org/x/tools/gopls/internal/cache.(*analysisNode)._import:+1
golang.org/x/tools/gopls/internal/cache.(*analysisNode).typeCheck.func2:+34
golang.org/x/tools/gopls/internal/cache.importerFunc.Import:+0
go/types.(*Checker).importPackage:+28
go/types.(*Checker).collectObjects.func1:+13
go/types.(*Checker).walkDecl:+9
go/types.(*Checker).walkDecls:=399
go/types.(*Checker).collectObjects:+42
go/types.(*Checker).checkFiles:+29
go/types.(*Checker).Files:=373
golang.org/x/tools/gopls/internal/cache.(*analysisNode).typeCheck:+118

golang.org/x/tools/gopls@v0.15.1 devel darwin/arm64 vscode (1)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

adonovan · 2024-04-04T18:12:27Z

This stack qOlVPg was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Errorf:+2
golang.org/x/tools/gopls/internal/cache.(*analysisNode)._import.func1:+41
sync.(*Once).doSlow:+5
sync.(*Once).Do:=65
golang.org/x/tools/gopls/internal/cache.(*analysisNode)._import:+1
golang.org/x/tools/gopls/internal/cache.(*analysisNode).typeCheck.func2:+34
golang.org/x/tools/gopls/internal/cache.importerFunc.Import:+0
go/types.(*Checker).importPackage:+28
go/types.(*Checker).collectObjects.func1:+13
go/types.(*Checker).walkDecl:+9
go/types.(*Checker).walkDecls:=391
go/types.(*Checker).collectObjects:+42
go/types.(*Checker).checkFiles:+18
go/types.(*Checker).Files:=304
golang.org/x/tools/gopls/internal/cache.(*analysisNode).typeCheck:+118

golang.org/x/tools/gopls@v0.15.2 go1.20.6 windows/amd64 vscode (1)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

adonovan · 2024-04-23T15:10:46Z

This stack sNopAA was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Errorf:+2
golang.org/x/tools/gopls/internal/cache.(*analysisNode)._import.func1:+41
sync.(*Once).doSlow:+5
sync.(*Once).Do:=65
golang.org/x/tools/gopls/internal/cache.(*analysisNode)._import:+1
golang.org/x/tools/gopls/internal/cache.(*analysisNode).typeCheck.func2:+34
golang.org/x/tools/gopls/internal/cache.importerFunc.Import:+0
go/types.(*Checker).importPackage:+28
go/types.(*Checker).collectObjects.func1:+13
go/types.(*Checker).walkDecl:+9
go/types.(*Checker).walkDecls:=391
go/types.(*Checker).collectObjects:+42
go/types.(*Checker).checkFiles:+32
go/types.(*Checker).Files:=341
golang.org/x/tools/gopls/internal/cache.(*analysisNode).typeCheck:+115

golang.org/x/tools/gopls@v0.15.3 go1.21.2 linux/amd64 vscode (1)
golang.org/x/tools/gopls@v0.15.3-pre.2 go1.21.2 linux/amd64 vscode (3)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

adonovan · 2024-04-23T15:11:07Z

This stack NpfwVg was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Errorf:+2
golang.org/x/tools/gopls/internal/cache.(*analysisNode)._import.func1:+41
sync.(*Once).doSlow:+5
sync.(*Once).Do:=65
golang.org/x/tools/gopls/internal/cache.(*analysisNode)._import:+1
golang.org/x/tools/gopls/internal/cache.(*analysisNode).typeCheck.func2:+34
golang.org/x/tools/gopls/internal/cache.importerFunc.Import:+0
go/types.(*Checker).importPackage:+28
go/types.(*Checker).collectObjects.func1:+13
go/types.(*Checker).walkDecl:+9
go/types.(*Checker).walkDecls:=399
go/types.(*Checker).collectObjects:+42
go/types.(*Checker).checkFiles:+29
go/types.(*Checker).Files:=372
golang.org/x/tools/gopls/internal/cache.(*analysisNode).typeCheck:+115

golang.org/x/tools/gopls@v0.15.3 go1.22.1 linux/amd64 vscode (1)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

adonovan · 2024-04-25T17:14:31Z

This stack rcxYqw was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Errorf:+2
golang.org/x/tools/gopls/internal/cache.(*analysisNode)._import.func1:+41
sync.(*Once).doSlow:+5
sync.(*Once).Do:=65
golang.org/x/tools/gopls/internal/cache.(*analysisNode)._import:+1
golang.org/x/tools/gopls/internal/cache.(*analysisNode).typeCheck.func2:+34
golang.org/x/tools/gopls/internal/cache.importerFunc.Import:+0
go/types.(*Checker).importPackage:+28
go/types.(*Checker).collectObjects.func1:+10
go/types.(*Checker).walkDecl:+9
go/types.(*Checker).walkDecls:=383
go/types.(*Checker).collectObjects:+42
go/types.(*Checker).checkFiles:+18
go/types.(*Checker).Files:=307
golang.org/x/tools/gopls/internal/cache.(*analysisNode).typeCheck:+118

golang.org/x/tools/gopls@v0.15.2 go1.19.13 darwin/amd64 vscode (1)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

adonovan added the gopls/telemetry-wins label Nov 17, 2023

gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Nov 17, 2023

gopherbot added this to the Unreleased milestone Nov 17, 2023

adonovan changed the title ~~x/tools/gopls: bug reported by telemetry [sbGdaw]~~ x/tools/gopls: bug in analysis importer reported by telemetry [sbGdaw] Nov 17, 2023

adonovan changed the title ~~x/tools/gopls: bug in analysis importer reported by telemetry [sbGdaw]~~ x/tools/gopls: bug in analysis importer reported by telemetry Nov 17, 2023

adonovan added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Nov 17, 2023

findleyr modified the milestones: Unreleased, gopls/v0.15.0 Nov 17, 2023

adonovan mentioned this issue Dec 1, 2023

x/tools/gopls: improve instrumentation for corrupt export data during import #63822

Open

findleyr modified the milestones: gopls/v0.15.0, gopls/v0.16.0 Feb 6, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

x/tools/gopls: bug in analysis importer reported by telemetry #64236

x/tools/gopls: bug in analysis importer reported by telemetry #64236

adonovan commented Nov 17, 2023 •

edited

findleyr commented Feb 6, 2024

adonovan commented Feb 27, 2024

adonovan commented Feb 27, 2024

adonovan commented Mar 9, 2024

adonovan commented Mar 13, 2024

adonovan commented Mar 21, 2024

adonovan commented Apr 4, 2024

adonovan commented Apr 23, 2024

adonovan commented Apr 23, 2024

adonovan commented Apr 25, 2024

x/tools/gopls: bug in analysis importer reported by telemetry #64236

x/tools/gopls: bug in analysis importer reported by telemetry #64236

Comments

adonovan commented Nov 17, 2023 • edited

findleyr commented Feb 6, 2024

adonovan commented Feb 27, 2024

adonovan commented Feb 27, 2024

adonovan commented Mar 9, 2024

adonovan commented Mar 13, 2024

adonovan commented Mar 21, 2024

adonovan commented Apr 4, 2024

adonovan commented Apr 23, 2024

adonovan commented Apr 23, 2024

adonovan commented Apr 25, 2024

adonovan commented Nov 17, 2023 •

edited