Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: bundled http2 uses priority-based scheduler instead of round robin scheduler #64216

Open
WeidiDeng opened this issue Nov 17, 2023 · 4 comments · May be fixed by #64218
Open

net/http: bundled http2 uses priority-based scheduler instead of round robin scheduler #64216

WeidiDeng opened this issue Nov 17, 2023 · 4 comments · May be fixed by #64218
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Go1.23

Comments

@WeidiDeng
Copy link

What version of Go are you using (go version)?

$ go version
1.21.4

Does this issue reproduce with the latest release?

Yes

What did you expect to see?

Bundled http2 uses round robin scheduler.

What did you see instead?

By default, bundled http2 support should use round robin scheduler according to this comment and commit. Howerver, it will still use the old priority scheduler because this field is set, which prevented the default behavior from happening.
@WeidiDeng WeidiDeng linked a pull request Nov 17, 2023 that will close this issue
Open
@gopherbot
Copy link

Change https://go.dev/cl/543178 mentions this issue: net/http: bundled http2 uses the new round-robin scheduler

@bcmills
Copy link
Contributor

bcmills commented Nov 17, 2023

(attn @neild)

@mknyszek mknyszek changed the title net/http: Bundled http2 uses priory scheduler instead of round robin scheduler net/http: Bundled http2 uses priority-based scheduler instead of round robin scheduler Nov 20, 2023
@mknyszek mknyszek added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Nov 20, 2023
@mknyszek mknyszek added this to the Backlog milestone Nov 20, 2023
@seankhliao seankhliao changed the title net/http: Bundled http2 uses priority-based scheduler instead of round robin scheduler net/http: bundled http2 uses priority-based scheduler instead of round robin scheduler Nov 21, 2023
@linxiulei
Copy link

Gentle ping @WeidiDeng. Your CL https://go.dev/cl/543178 is ready to submit. Would you like to submit it?

@bcmills bcmills modified the milestones: Backlog, Go1.23 Jan 4, 2024
@bcmills
Copy link
Contributor

bcmills commented Jan 4, 2024

I think at this point in the release cycle, changing the http2 scheduler would need a freeze exception from @golang/release — RC1 is out for testing and does not include the change, which seems like it may be significant for some users.

@linxiulei linxiulei mentioned this issue Jan 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Go1.23
Development

Successfully merging a pull request may close this issue.

net/http: bundled http2 uses the new round-robin scheduler WeidiDeng/go
5 participants
@linxiulei @mknyszek @bcmills @gopherbot @WeidiDeng