-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/build: add support for running google.golang.org/protobuf integration test on LUCI builders #64066
Labels
Builders
x/build issues (builders, bots, dashboards)
FrozenDueToAge
NeedsFix
The path to resolution is known, but the work has not been done.
Milestone
Comments
dmitshur
added
Builders
x/build issues (builders, bots, dashboards)
NeedsInvestigation
Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
labels
Nov 10, 2023
Change https://go.dev/cl/541123 mentions this issue: |
Change https://go.dev/cl/547116 mentions this issue: |
gopherbot
pushed a commit
to golang/build
that referenced
this issue
Dec 6, 2023
This dependency is needed for running the protobuf integration test. Add it only on linux/amd64 longtest builders, where the integration test runs and the CIPD package is available. For golang/go#64066. Change-Id: Ic29406a28fd02a218a788cd4fd552158b5f3894e Reviewed-on: https://go-review.googlesource.com/c/build/+/547116 Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> TryBot-Bypass: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Michael Knyszek <mknyszek@google.com> Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Change https://go.dev/cl/548115 mentions this issue: |
gopherbot
pushed a commit
to protocolbuffers/protobuf-go
that referenced
this issue
Dec 7, 2023
Drop -mod=vendor because it's not needed by now. There are multiple reasons for this: 1) integration_test.go has no external dependencies, 2) there's no checked-in vendor directory, 3) CL 544855 deleted the last 'go mod vendor' invocation in code, and 4) now that the go.mod has a go directive at 1.14+ (CL 547337), automatic vendoring¹ is on. For golang/go#64066. ¹ https://go.dev/doc/go1.14#vendor, https://go.dev/ref/mod#vendoring Change-Id: If8f3ea85d560b2796a2ccdb4ae7dbc38f0760982 Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/548115 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Michael Stapelberg <stapelberg@google.com>
dmitshur
added
NeedsFix
The path to resolution is known, but the work has not been done.
and removed
NeedsInvestigation
Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
labels
Dec 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Builders
x/build issues (builders, bots, dashboards)
FrozenDueToAge
NeedsFix
The path to resolution is known, but the work has not been done.
Basic pre- and post-submit for the protobuf repo was added in #63597, but there's more work to for it to be possible to run protobuf's custom integration test in CI. This is the tracking issue for that work.
CC @stapelberg, @golang/release.
The text was updated successfully, but these errors were encountered: