Skip to content

x/exp/cmd/gorelease: unexpected go.sum complaint #64051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
PaulForgey-Discovery opened this issue Nov 10, 2023 · 6 comments
Closed

x/exp/cmd/gorelease: unexpected go.sum complaint #64051

PaulForgey-Discovery opened this issue Nov 10, 2023 · 6 comments
Labels
WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Milestone
Unreleased

Comments

@PaulForgey-Discovery
Copy link

What version of Go are you using (go version)?

$ go version
go version go1.20.10 darwin/arm64

Does this issue reproduce with the latest release?

unknown (our organization is using go1.20.latest)

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE=""
GOARCH="arm64"
GOBIN=""
GOCACHE="/Users/paul.forgey/Library/Caches/go-build"
GOENV="/Users/paul.forgey/Library/Application Support/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="arm64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/paul.forgey/go/pkg/mod"
GONOPROXY="github.com/wbd-streaming/*"
GONOSUMDB="github.com/wbd-streaming/*"
GOOS="darwin"
GOPATH="/Users/paul.forgey/go"
GOPRIVATE="github.com/wbd-streaming/*"
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/Users/paul.forgey/goroot"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/Users/paul.forgey/goroot/pkg/tool/darwin_arm64"
GOVCS=""
GOVERSION="go1.20.10"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/paul.forgey/go/src/github.com/wbd-streaming/wbd-go-common/go.mod"
GOWORK=""
CGO_CFLAGS="-O2 -g"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-O2 -g"
CGO_FFLAGS="-O2 -g"
CGO_LDFLAGS="-O2 -g"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -arch arm64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/9h/m7vdp5bn39n3p28g91swgphw0000gq/T/go-build737174559=/tmp/go-build -gno-record-gcc-switches -fno-common"

also reproduces in linux

What did you do?

$ gorelease -version=v1.6.0

What did you expect to see?

normal output

What did you see instead?

# diagnostics
go.sum: one or more sums are missing. Run 'go mod tidy' to add missing sums.

There is actually nothing wrong with the go.sum file and re-generating it by deleting and re-runninggo mod tidy produces the same contents.

The package builds just fine.
@seankhliao seankhliao changed the title gorelease: unexpected go.sum complaint x/exp/cmd/gorelease: unexpected go.sum complaint Nov 10, 2023
@gopherbot gopherbot added this to the Unreleased milestone Nov 10, 2023
@seankhliao
Copy link
Member

what version of gorelease is this, and can you provide a reproducer?

@seankhliao seankhliao added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Nov 10, 2023
@PaulForgey-Discovery
Copy link
Author

PaulForgey-Discovery commented Nov 12, 2023 •
edited
Loading

what version of gorelease is this, and can you provide a reproducer?

unfortunately, I haven't been able to get a sanitized reproduction outside our production code. This is still reproducing @latest (Nov 10, 2023). Has been since the Sep 5, 2023 release but the problem actually started reproducing when we bumped the version of go in this module from 1.18 to 1.20.

And, yes, when we did so, we re-ran go mod tidy. I can even delete the go.sum and rebuild it with the same resulting go.sum.

@PaulForgey-Discovery
Copy link
Author

as a test, I tried installing all tagged versions of gorelease to see if it starts reproducing somewhere, and the behavior is present in all but the first release, which panics.

@seankhliao seankhliao added WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. and removed WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. labels Nov 14, 2023
@gopherbot
Copy link
Contributor

Timed out in state WaitingForInfo. Closing.

(I am just a bot, though. Please speak up if this is a mistake or you have the requested information.)

@gopherbot gopherbot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 14, 2023
@PaulForgey-Discovery
Copy link
Author

no longer reproducing in go1.21, but still does reproduce in go1.20 latest

@kramvan1
Copy link

reproduced with go 1.22.9 with version v0.0.0-20241009180824-f66d83c29e7c
And yes, go mod tidy, makes no difference.

@kramvan1 kramvan1 mentioned this issue Nov 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@kramvan1 @gopherbot @seankhliao @PaulForgey-Discovery