Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/debug/internal/gocore: allocation headers break viewcore tests #64049

Closed
mknyszek opened this issue Nov 9, 2023 · 6 comments
Closed

x/debug/internal/gocore: allocation headers break viewcore tests #64049

mknyszek opened this issue Nov 9, 2023 · 6 comments
Assignees
@mknyszek
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Milestone
Go1.22

Comments

@mknyszek
Copy link
Contributor

mknyszek commented Nov 9, 2023 •
edited
Loading 

#!watchflakes
post <- pkg == "golang.org/x/debug" && `TestVersions/goroot`

The new allocation headers change modifies how the heap metadata is laid out, which unsurprisingly breaks the x/debug viewcore tests that care about that kind of thing.

Example failure: https://build.golang.org/log/921d95ba40810cde564beec65d12b3714c642e57
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Nov 9, 2023
@gopherbot gopherbot added this to the Unreleased milestone Nov 9, 2023
@mknyszek mknyszek self-assigned this Nov 9, 2023
@mknyszek mknyszek added the NeedsFix The path to resolution is known, but the work has not been done. label Nov 9, 2023
@mknyszek mknyszek mentioned this issue Nov 10, 2023
Closed
@mknyszek mknyszek changed the title x/debug: allocation headers break viewcore tests x/debug/internal/gocore: allocation headers break viewcore tests Nov 10, 2023
@mknyszek
Copy link
Contributor Author

Broken as of https://go.dev/cl/538217.

@mknyszek mknyszek moved this from Todo to In Progress in Go Compiler / Runtime Nov 10, 2023
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/541131 mentions this issue: internal/gocore: refactor heapArena reading

gopherbot pushed a commit to golang/debug that referenced this issue Nov 10, 2023
@prattmic
internal/gocore: refactor heapArena reading
a36bd79 
There are a lot of different historical changes to the heap arena
structure, making Process.readHeap difficult to follow. Refactor to
split out version-specific logic to individual methods.

Reading allocation headers is not yet supported by this CL.

For golang/go#64049.

Change-Id: Ia4198bd8492d8426c7a2cc8671b78c49ab6b7161
Reviewed-on: https://go-review.googlesource.com/c/debug/+/541131
Reviewed-by: Michael Knyszek <mknyszek@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
@dmitshur
Copy link
Contributor

@mknyszek There's a release-blocker label here, but it's in Unreleased milestone meaning it's not blocking any release. Did you mean for this to be a blocker for Go 1.22 (RC 1), or something else?

@mknyszek
Copy link
Contributor Author

It's an okay-after-rc1 release blocker. I'll move it into the Go 1.22 milestone.

@mknyszek mknyszek modified the milestones: Unreleased, Go1.22 Dec 11, 2023
@mknyszek mknyszek added the okay-after-rc1 Used by release team to mark a release-blocker issue as okay to resolve either before or after rc1 label Dec 11, 2023
@mknyszek
Copy link
Contributor Author

Actually, it might be even lower priority than that. Turns out this package has been (unsurprisingly) broken for a while now.

@gopherbot gopherbot removed the okay-after-rc1 Used by release team to mark a release-blocker issue as okay to resolve either before or after rc1 label Dec 19, 2023
@mknyszek
Copy link
Contributor Author

Deduplicating this with #63359.

@mknyszek mknyszek closed this as not planned Won't fix, can't repro, duplicate, stale Jan 10, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Go Compiler / Runtime Jan 10, 2024
@golang golang locked and limited conversation to collaborators Jan 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mknyszek mknyszek

Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Projects
Release Blockers
Status: Done
Milestone
Go1.22
Development

No branches or pull requests
3 participants
@mknyszek @dmitshur @gopherbot