Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proposal: x/sys/execabs: deprecate the package #64047

Open
rolandshoemaker opened this issue Nov 9, 2023 · 4 comments
Open

proposal: x/sys/execabs: deprecate the package #64047

rolandshoemaker opened this issue Nov 9, 2023 · 4 comments
Labels
Proposal
Milestone
Proposal

Comments

@rolandshoemaker
Copy link
Member

x/sys/execabs was introduced after we introduced the internal/execabs package in 2021 in order to fix a security issue, so that the same functionality could be used in external packages. In 1.19 we changed the default behavior of os/exec to match internal/execabs, and removed that package.

At this point it seems reasonable to deprecate x/sys/execabs, and point people at os/exec again.
@gopherbot gopherbot added this to the Proposal milestone Nov 9, 2023
@bcmills
Copy link
Contributor

bcmills commented Nov 9, 2023

This seems like it would be a great use-case for //go:fix inlining (#32816) once we have that. 🙃

@seankhliao
Copy link
Member

just deprecate or tag/isolate/delete?

@bcmills
Copy link
Contributor

bcmills commented Nov 10, 2023

It probably has enough existing usage that we shouldn't tag-and-delete yet. (Most of the other tag-and-delete packages were unmaintained and virtually unused for many years prior to deletion.)

But I wonder if we should put this on hold until we have a //go:fix tool available, to minimize the amount of work needed for users to resolve the deprecation notices. Given that it is such a thin wrapper around os/exec, the maintenance cost of keeping it around in the meantime doesn't seem particularly high.

@rolandshoemaker
Copy link
Member Author

I think postponing until we have //go:fix support is reasonable, we're not really in a rush.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Proposal
Projects
Proposals
Status: Incoming
Milestone
Proposal
Development

No branches or pull requests
4 participants
@rolandshoemaker @bcmills @gopherbot @seankhliao