Skip to content

x/tools/gopls: CPU usage performance regression following CL 539676 #64011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
findleyr opened this issue Nov 8, 2023 · 1 comment
Closed

x/tools/gopls: CPU usage performance regression following CL 539676 #64011

findleyr opened this issue Nov 8, 2023 · 1 comment
Assignees
@findleyr
Labels
FrozenDueToAge gopls/performance Issues related to gopls performance (CPU, memory, etc). gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.15.0

Comments

@findleyr
Copy link
Member

findleyr commented Nov 8, 2023

I just noticed in our performance dashboards that https://go.dev/cl/539676 appears to have introduced a rather significant regression in total CPU (e.g. the 'Typing' benchmarks).

I don't immediately know why, but we must investigate and fix before the next release. We can certainly revert that CL if necessary.
@findleyr findleyr added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository. gopls/performance Issues related to gopls performance (CPU, memory, etc). labels Nov 8, 2023
@findleyr findleyr added this to the gopls/v0.15.0 milestone Nov 8, 2023
@findleyr findleyr self-assigned this Nov 8, 2023
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/542620 mentions this issue: Revert "gopls/internal/lsp/cache: remove baseCtx from the View"

@golang golang locked and limited conversation to collaborators Nov 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@findleyr findleyr

Labels
FrozenDueToAge gopls/performance Issues related to gopls performance (CPU, memory, etc). gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.15.0
Development

No branches or pull requests
2 participants
@gopherbot @findleyr