New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: CPU usage performance regression following CL 539676 #64011

Closed

findleyr opened this issue Nov 8, 2023 · 1 comment

Assignees

Labels

gopls/performance gopls NeedsInvestigation Tools

Milestone

Contributor

findleyr commented Nov 8, 2023

I just noticed in our performance dashboards that https://go.dev/cl/539676 appears to have introduced a rather significant regression in total CPU (e.g. the 'Typing' benchmarks).

I don't immediately know why, but we must investigate and fix before the next release. We can certainly revert that CL if necessary.

findleyr added NeedsInvestigation gopls Tools gopls/performance labels

findleyr added this to the gopls/v0.15.0 milestone

findleyr self-assigned this

gopherbot commented Nov 15, 2023

Change https://go.dev/cl/542620 mentions this issue: Revert "gopls/internal/lsp/cache: remove baseCtx from the View"

gopherbot closed this as completed in


      golang/tools@4a92712

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment