Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/gomoteserver: resolve dependency installation #63992

Closed
Tracked by #61772
cagedmantis opened this issue Nov 7, 2023 · 4 comments
Closed
Tracked by #61772

x/build/cmd/gomoteserver: resolve dependency installation #63992

cagedmantis opened this issue Nov 7, 2023 · 4 comments
Labels
Builders x/build issues (builders, bots, dashboards) FeatureRequest NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@cagedmantis
Copy link
Contributor

cagedmantis commented Nov 7, 2023 •
edited

Ensure that the dependencies needed for each build is installed on the gomote instance. We need to decide how essential this is to the project. We also need to determine the desired path forward.
@cagedmantis cagedmantis mentioned this issue Nov 7, 2023
Closed
37 tasks
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Nov 7, 2023
@gopherbot gopherbot added this to the Unreleased milestone Nov 7, 2023
@cagedmantis cagedmantis added the NeedsFix The path to resolution is known, but the work has not been done. label Nov 7, 2023
@gopherbot
Copy link

Change https://go.dev/cl/541436 mentions this issue: internal/gomote: fix buildlet startup on all platforms

gopherbot pushed a commit to golang/build that referenced this issue Nov 14, 2023
@cagedmantis
internal/gomote: fix buildlet startup on all platforms
3cf4c0a 
This change adds the required configuration so that the buildlet will
start in all platforms. The start task proto has also been refactored
to not use deprecated fields. The shebang has been removed from the
Python script. Pagination support has been added to the list builders
buildbucket call.

For golang/go#63992

Change-Id: I0ff2ddb30780e03ee719757720996ae0e33b341a
Reviewed-on: https://go-review.googlesource.com/c/build/+/541436
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
@gopherbot
Copy link

Change https://go.dev/cl/542256 mentions this issue: internal/gomote: update package dependencies

gopherbot pushed a commit to golang/build that referenced this issue Nov 15, 2023
@cagedmantis @gopherbot
internal/gomote: update package dependencies
52b5fb2 
The cpython3 dependency should only be installed on Windows and
Darwin. We can't be sure that the package exists for all other
platforms.

Updates golang/go#63992

Change-Id: I1d1063efc830eb9d347c5e18c0989bc1f5fe727b
Reviewed-on: https://go-review.googlesource.com/c/build/+/542256
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Carlos Amedee <carlos@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
@cagedmantis
Copy link
Contributor Author

The team has decided that this can be resolved as a feature in the future.

@dmitshur dmitshur changed the title x/build/gomoteserver: resolve dependency installation x/build/cmd/gomoteserver: resolve dependency installation Feb 20, 2024
@cagedmantis
Copy link
Contributor Author

We now use golangbuild to install dependencies. Thanks @mknyszek

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FeatureRequest NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Release
Status: Done
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@cagedmantis @dmitshur @gopherbot