Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/gomoteserver: enable SSH server #63991

Closed
Tracked by #61772
cagedmantis opened this issue Nov 7, 2023 · 5 comments
Closed
Tracked by #61772

x/build/gomoteserver: enable SSH server #63991

cagedmantis opened this issue Nov 7, 2023 · 5 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@cagedmantis
Copy link
Contributor

cagedmantis commented Nov 7, 2023

Experiment with running an in-process SSH server instead of using a system installed sshd.

@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Nov 7, 2023
@gopherbot gopherbot added this to the Unreleased milestone Nov 7, 2023
@cagedmantis cagedmantis added the NeedsFix The path to resolution is known, but the work has not been done. label Nov 7, 2023
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/541377 mentions this issue: cmd/coordinator: set SSH server Host keys

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/541438 mentions this issue: internal/coordinator/remote: add LUCI SSH handler

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/541381 mentions this issue: cmd/buildlet: add an SSH server to the buildlet

gopherbot pushed a commit to golang/build that referenced this issue Nov 10, 2023

Verified

This commit was signed with the committer’s verified signature.
myitcv Paul Jolly
The host keys should remain static for usability purposes. This change
prevents the user from having to delete a known host entry each time
the server is restarted.

For golang/go#63991

Change-Id: I408c2c89fd0f2b8603a8a91a8c2946d07584c7d7
Reviewed-on: https://go-review.googlesource.com/c/build/+/541377
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
gopherbot pushed a commit to golang/build that referenced this issue Nov 10, 2023

Verified

This commit was signed with the committer’s verified signature.
myitcv Paul Jolly
This change adds a LUCI specific SHH connection handler. It enables
communication with buildlets running in swarming tasks.

For golang/go#63991

Change-Id: Id38c6e672abd4f6952b1f4c52da55d8caa58cede
Reviewed-on: https://go-review.googlesource.com/c/build/+/541438
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
@cagedmantis cagedmantis moved this to In Progress in Go Release Nov 14, 2023
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/542255 mentions this issue: internal/coordinator/remote: do not cd into go src directory

@github-project-automation github-project-automation bot moved this from In Progress to Done in Go Release Nov 15, 2023
gopherbot pushed a commit to golang/build that referenced this issue Nov 15, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
This change makes sure the client does not cd into the go source
directory since it is not guaranteed to exist.

For golang/go#63991

Change-Id: I31c59b437eee616ff57efc5233a8206856697375
Reviewed-on: https://go-review.googlesource.com/c/build/+/542255
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Carlos Amedee <carlos@golang.org>
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/543096 mentions this issue: cmd/buildlet: add an SSH server for Windows

gopherbot pushed a commit to golang/build that referenced this issue Nov 20, 2023
This change adds a SSH server implementation for the buildlet when
running on Windows.

For golang/go#63991

Change-Id: I782ad73a219a42b770e0e96c5b8f1a9eeb4aa98f
Reviewed-on: https://go-review.googlesource.com/c/build/+/543096
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Carlos Amedee <carlos@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
@golang golang locked and limited conversation to collaborators Nov 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
Archived in project
Development

No branches or pull requests

2 participants