Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: git VCS qualifier in module path uses git:// scheme [1.20 backport] #63972

Closed
gopherbot opened this issue Nov 6, 2023 · 2 comments
Closed

cmd/go: git VCS qualifier in module path uses git:// scheme [1.20 backport] #63972

gopherbot opened this issue Nov 6, 2023 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases GoCommand cmd/go release-blocker Security
Milestone
Go1.20.12

Comments

@gopherbot
Copy link

@bcmills requested issue #63845 to be considered for backport to the next 1.20 minor release.

@gopherbot, please backport to Go 1.21 and 1.20.
@gopherbot gopherbot added CherryPickCandidate Used during the release process for point releases GoCommand cmd/go labels Nov 6, 2023
@gopherbot gopherbot mentioned this issue Nov 6, 2023
Closed
@gopherbot gopherbot added this to the Go1.20.11 milestone Nov 6, 2023
@bcmills bcmills added CherryPickApproved Used during the release process for point releases release-blocker labels Nov 6, 2023
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Nov 6, 2023
@gopherbot
Copy link
Author

Change https://go.dev/cl/540335 mentions this issue: [release-branch.go1.20] cmd/go/internal/vcs: error out if the requested repo does not support a secure protocol

@gopherbot gopherbot modified the milestones: Go1.20.11, Go1.20.12 Nov 7, 2023
@gopherbot
Copy link
Author

Closed by merging 46bc338 to release-branch.go1.20.

gopherbot pushed a commit that referenced this issue Nov 27, 2023
@gopherbot
[release-branch.go1.20] cmd/go/internal/vcs: error out if the request…
46bc338 
…ed repo does not support a secure protocol

Updates #63845.
Fixes #63972.

Change-Id: If86d6b13d3b55877b35c087112bd76388c9404b8
Reviewed-on: https://go-review.googlesource.com/c/go/+/539321
Reviewed-by: Michael Matloob <matloob@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Roland Shoemaker <roland@golang.org>
Auto-Submit: Bryan Mills <bcmills@google.com>
(cherry picked from commit be26ae1)
Reviewed-on: https://go-review.googlesource.com/c/go/+/540335
Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
rcrozean pushed a commit to rcrozean/go that referenced this issue Dec 7, 2023
@rcrozean
[release-branch.go1.20] cmd/go/internal/vcs: error out if the request…
2043cf7 
…ed repo does not support a secure protocol

Updates golang#63845.
Fixes golang#63972.

Change-Id: If86d6b13d3b55877b35c087112bd76388c9404b8
Reviewed-on: https://go-review.googlesource.com/c/go/+/539321
Reviewed-by: Michael Matloob <matloob@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Roland Shoemaker <roland@golang.org>
Auto-Submit: Bryan Mills <bcmills@google.com>
(cherry picked from commit be26ae1)
Reviewed-on: https://go-review.googlesource.com/c/go/+/540335
Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
rcrozean pushed a commit to rcrozean/go that referenced this issue Dec 8, 2023
@rcrozean
[release-branch.go1.20] cmd/go/internal/vcs: error out if the request…
13a6e63 
…ed repo does not support a secure protocol

Updates golang#63845.
Fixes golang#63972.

Change-Id: If86d6b13d3b55877b35c087112bd76388c9404b8
Reviewed-on: https://go-review.googlesource.com/c/go/+/539321
Reviewed-by: Michael Matloob <matloob@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Roland Shoemaker <roland@golang.org>
Auto-Submit: Bryan Mills <bcmills@google.com>
(cherry picked from commit be26ae1)
Reviewed-on: https://go-review.googlesource.com/c/go/+/540335
Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases GoCommand cmd/go release-blocker Security
Projects
None yet
Milestone
Go1.20.12
Development

No branches or pull requests
3 participants
@dmitshur @bcmills @gopherbot