Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: duplicate escaping on error page #63968

Closed
findleyr opened this issue Nov 6, 2023 · 3 comments
Closed

x/pkgsite: duplicate escaping on error page #63968

findleyr opened this issue Nov 6, 2023 · 3 comments
Labels
NeedsFix The path to resolution is known, but the work has not been done. pkgsite
Milestone
pkgsite/backlog

Comments

@findleyr
Copy link
Contributor

findleyr commented Nov 6, 2023

Via @rsc, who encountered the following broken escaping on pkgsite:
image

Repro steps:

  1. Visit https://pkg.go.dev/rsc.io/tmp/nonexist
  2. Click "Fetch" button.
  3. Wait for the load to fail.
@gopherbot gopherbot added this to the Unreleased milestone Nov 6, 2023
@findleyr
Copy link
Contributor Author

findleyr commented Nov 6, 2023

Interestingly, the test appears to look for this escaping explicitly:
https://cs.opensource.google/go/x/pkgsite/+/master:internal/frontend/fetchserver/fetch_test.go;l=170;drc=ebe617b30c52774fccf9d36331cbff31e99aaf9e

@findleyr
Copy link
Contributor Author

findleyr commented Nov 6, 2023

Hmm, I don't know if/how this ever worked. Perhaps @jba recalls?

fetch.ts uses new DOMParser().parseFromString(...), but that doesn't unescape:
image

@suzmue suzmue modified the milestones: Unreleased, pkgsite/backlog Nov 10, 2023
@suzmue suzmue added the NeedsFix The path to resolution is known, but the work has not been done. label Nov 10, 2023
@findleyr findleyr mentioned this issue Feb 15, 2024
Closed
@hyangah
Copy link
Contributor

hyangah commented Feb 20, 2024

Screenshot 2024-02-20 at 1 30 40 PM
I guess this was fixed just by updating the pkgsite backend... last week.

@hyangah hyangah closed this as not planned Won't fix, can't repro, duplicate, stale Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsFix The path to resolution is known, but the work has not been done. pkgsite
Projects
None yet
Milestone
pkgsite/backlog
Development

No branches or pull requests
4 participants
@hyangah @suzmue @gopherbot @findleyr