Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/godoc: Second level package documentation broken #63950

Closed
achenet opened this issue Nov 5, 2023 · 6 comments
Closed

x/tools/godoc: Second level package documentation broken #63950

achenet opened this issue Nov 5, 2023 · 6 comments
Labels
NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. Tools This label describes issues relating to any tools in the x/tools repository. WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Milestone
Unplanned

Comments

@achenet
Copy link

achenet commented Nov 5, 2023

What version of Go are you using (go version)?

go version go1.21.1 linux/amd64

Does this issue reproduce with the latest release?

Unsure

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE=''
GOARCH='amd64'
GOBIN=''
GOCACHE='/home/utilisateur/.cache/go-build'
GOENV='/home/utilisateur/.config/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFLAGS=''
GOHOSTARCH='amd64'
GOHOSTOS='linux'
GOINSECURE=''
GOMODCACHE='/home/utilisateur/go/bin/pkg/mod'
GONOPROXY=''
GONOSUMDB=''
GOOS='linux'
GOPATH='/home/utilisateur/go/bin'
GOPRIVATE=''
GOPROXY='https://proxy.golang.org,direct'
GOROOT='/usr/local/go'
GOSUMDB='sum.golang.org'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/usr/local/go/pkg/tool/linux_amd64'
GOVCS=''
GOVERSION='go1.21.1'
GCCGO='gccgo'
GOAMD64='v1'
AR='ar'
CC='gcc'
CXX='g++'
CGO_ENABLED='1'
GOMOD='/dev/null'
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -m64 -pthread -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=/tmp/go-build448943707=/tmp/go-build -gno-record-gcc-switches'

What did you do?

I fired up godoc with godoc -http=":6060" &, and tried to access the page for net/http. I also tried net, os and encoding/json.

What did you expect to see?

I expected the pages for net/http and encoding/json to function normally.

What did you see instead?

/src/encoding/json/encode.go:963:18: expected '(', found '['
found packages http (alpn_test.go) and main (triv.go) in /src/net/http
os,net and encoding all worked normally.
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Nov 5, 2023
@gopherbot gopherbot added this to the Unreleased milestone Nov 5, 2023
@seankhliao
Copy link
Member

see also #59056

@heschi
Copy link
Contributor

heschi commented Nov 6, 2023

cc @alandonovan @findleyr, I guess?

@heschi heschi added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Nov 6, 2023
@findleyr
Copy link
Contributor

findleyr commented Nov 6, 2023

@achenet per #59056, we're working on getting x/pkgsite/cmd/pkgsite up to the point where we can delete godoc.

Is there a reason you can use cmd/pkgsite?

@achenet
Copy link
Author

achenet commented Nov 6, 2023 via email

@go101
Copy link

go101 commented Nov 7, 2023

Another alternative is Golds.

@findleyr findleyr modified the milestones: Unreleased, Unplanned Nov 7, 2023
@seankhliao seankhliao added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Dec 8, 2023
@gopherbot
Copy link

Timed out in state WaitingForInfo. Closing.

(I am just a bot, though. Please speak up if this is a mistake or you have the requested information.)

@gopherbot gopherbot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. Tools This label describes issues relating to any tools in the x/tools repository. WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Projects
None yet
Milestone
Unplanned
Development

No branches or pull requests
6 participants
@gopherbot @seankhliao @achenet @go101 @heschi @findleyr