Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http/cgi: PATH_INFO should be empty or start with a slash #63925

Closed
aimuz opened this issue Nov 3, 2023 · 2 comments
Closed

net/http/cgi: PATH_INFO should be empty or start with a slash #63925

aimuz opened this issue Nov 3, 2023 · 2 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Go1.22

Comments

@aimuz
Copy link
Contributor

aimuz commented Nov 3, 2023

What version of Go are you using (go version)?

$ go version
go version go1.21.3 darwin/amd64

Does this issue reproduce with the latest release?

yes

What did you do?

As described at https://datatracker.ietf.org/doc/html/rfc3875#section-3.3 and https://datatracker.ietf.org/doc/html/rfc3875#section-4.1.5,

seems to require that PATH_INFO either is empty or begins with a slash, which would imply that the SCRIPT_NAME variable for this case must not end with a slash.

https://go-review.googlesource.com/c/go/+/538861/comment/d24b7001_5770e9f5/

What did you expect to see?

What did you see instead?
@aimuz aimuz changed the title net/http/cgi: PATH_INFO and SCRIPT_NAME do not conform to the rfc3875 standard net/http/cgi: PATH_INFO should be empty or start with a slash Nov 3, 2023
aimuz added a commit to aimuz/go that referenced this issue Nov 3, 2023
@aimuz
net/http/cgi: PATH_INFO should be empty or start with a slash
de79aa7 
Fixed PATH_INFO not starting with a slash as described in RFC 3875 for PATH_INFO

Fixes golang#63925
@aimuz aimuz mentioned this issue Nov 3, 2023
Closed
@gopherbot
Copy link

Change https://go.dev/cl/539615 mentions this issue: net/http/cgi: PATH_INFO should be empty or start with a slash

@bcmills bcmills added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Nov 3, 2023
@bcmills bcmills added this to the Backlog milestone Nov 3, 2023
@bcmills
Copy link
Contributor

bcmills commented Nov 3, 2023

(CC @neild @bradfitz)

aimuz added a commit to aimuz/go that referenced this issue Nov 3, 2023
@aimuz
net/http/cgi: PATH_INFO should be empty or start with a slash
2fccfd4 
Fixed PATH_INFO not starting with a slash as described in RFC 3875 for PATH_INFO

Fixes golang#63925
aimuz added a commit to aimuz/go that referenced this issue Nov 3, 2023
@aimuz
net/http/cgi: PATH_INFO should be empty or start with a slash
1c532e3 
Fixed PATH_INFO not starting with a slash as described in RFC 3875 for PATH_INFO

Fixes golang#63925
@bcmills bcmills modified the milestones: Backlog, Go1.22 Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Go1.22
Development

Successfully merging a pull request may close this issue.

net/http/cgi: the PATH_INFO should be empty or start with a slash aimuz/go
3 participants
@bcmills @gopherbot @aimuz