Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: test failure on Windows 8 #6392

Closed
rsc opened this issue Sep 15, 2013 · 7 comments
Closed

net: test failure on Windows 8 #6392

rsc opened this issue Sep 15, 2013 · 7 comments
Labels
FrozenDueToAge
Milestone
Go1.2

Comments

@rsc
Copy link
Contributor

rsc commented Sep 15, 2013 

I get this failure on a new Dell Inspiron running Windows 8, Go at tip (amd64/windows).
I believe I have turned off the firewall completely and I still get this error.

--- FAIL: TestConnICMPEcho (0.00 seconds)
    ipraw_test.go:104: Dial failed: dial ip4:icmp 127.0.0.1: An attempt was made to access a socket in a way forbidden by its access permissions.
--- FAIL: TestPacketConnICMPEcho (0.00 seconds)
    ipraw_test.go:178: ListenPacket failed: listen ip4:icmp 0.0.0.0: An attempt was made to access a socket in a way forbidden by its access permissions.
--- FAIL: TestPacketConn (0.00 seconds)
    packetconn_test.go:102: ListenPacket failed: listen ip:icmp 127.0.0.1: An attempt was made to access a socket in a way forbidden by its access permissions.
--- FAIL: TestConnAndPacketConn (0.00 seconds)
    packetconn_test.go:159: ListenPacket failed: listen ip:icmp 127.0.0.1: An attempt was made to access a socket in a way forbidden by its access permissions.
--- FAIL: TestIPConnSpecificMethods (0.00 seconds)
    protoconn_test.go:192: ListenIP failed: listen ip4:icmp 127.0.0.1: An attempt was made to access a socket in a way forbidden by its access permissions.
FAIL
FAIL    net 3.224s
@rsc
Copy link
Contributor Author

rsc commented Sep 15, 2013

Comment 1:

I uninstalled the McAfee trialware that was on my computer and now Windows Firewall
tells me about the net.test being blocked at least.
It looks like it is icmp only. We should probably disable those except when in "external
network" mode, at least on Windows. I'll send a CL.

@alexbrainman
Copy link
Member

Comment 2:

I asked mikio to have this test running unconditionally
https://golang.org/cl/12843043#msg9 because library code was broken and we
didn't noticed. I suspect the test might not always work for a security reason, so
perhaps we need to backout sometimes. I tried this test here on all my systems and on
our builders, and it worked everywhere. But I suspect that everywhere I looked, logged
in user is memeber if "Administrators" group. Are you?
Regardless, I would like to keep running it on our builders. They are logged in as
"Administrator". So, perhaps, we can check for that.
Alex

@rsc
Copy link
Contributor Author

rsc commented Sep 16, 2013

Comment 3:

I am not in the Administrators group, perhaps accidentally, but at the same time I think
all.bat should work for non-Administrators. The test failure keeps the build from
proceeding.
I will send a CL with some t.Skips and perhaps you can adjust it to look for
administrator?

@alexbrainman
Copy link
Member

Comment 4:

Sounds good. Thank you Russ. Whatever the case I would like our builders to test the
code.
Alex

@rsc
Copy link
Contributor Author

rsc commented Sep 16, 2013

Comment 5:

This issue was closed by revision d9fdf88.

Status changed to Fixed.

@alexbrainman
Copy link
Member

Comment 6:

Russ,
Please, try https://golang.org/cl/13422044/. It suppose to just skip tests you
had problem with automatically. Thank you.
Alex

@alexbrainman
Copy link
Member

Comment 7:

This issue was closed by revision b80ef1a.

@rsc rsc added fixed labels Sep 24, 2013
@rsc rsc added this to the Go1.2 milestone Apr 14, 2015
@rsc rsc removed the go1.2maybe label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 25, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.2
Development

No branches or pull requests
3 participants
@rsc @gopherbot @alexbrainman