Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/vet: don't report "loop variable captured" error for versions >= go1.22 #63891

Closed
griesemer opened this issue Nov 2, 2023 · 4 comments
Closed

cmd/vet: don't report "loop variable captured" error for versions >= go1.22 #63891

griesemer opened this issue Nov 2, 2023 · 4 comments
Labels
NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Milestone
Go1.22

Comments

@griesemer
Copy link
Contributor

griesemer commented Nov 2, 2023 •
edited

The new loop variable semantics (#60078) is enabled for go1.22 so go vet shouldn't report an error for captured loop variables anymore.

The playground at tip shows the new loop variable semantics but still reports a vet error.

Related to #57063.
@griesemer griesemer added the NeedsFix The path to resolution is known, but the work has not been done. label Nov 2, 2023
@griesemer griesemer added this to the Go1.22 milestone Nov 2, 2023
@griesemer
Copy link
Contributor Author

Tentatively marking this as a release blocker.

@griesemer
Copy link
Contributor Author

cc @timothy-king

@timothy-king
Copy link
Contributor

Duplicate of #63888 ?

@griesemer
Copy link
Contributor Author

Indeed! (I'm 6h behind despite being in the same time zone... :-)
Thanks for opening that other issue.
Closed as duplicate of #63888.

@dmitshur dmitshur closed this as not planned Won't fix, can't repro, duplicate, stale Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Projects
None yet
Milestone
Go1.22
Development

No branches or pull requests
3 participants
@timothy-king @dmitshur @griesemer