New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
encoding/asn1: simplify appendFourDigits #63879
Conversation
This PR (HEAD: c83dae1) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/538721. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/538721. |
Message from kyose chang: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/538721. |
c83dae1
to
938ea8a
Compare
This PR (HEAD: 938ea8a) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/538721. Important tips:
|
Message from kyose chang: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/538721. |
Message from qiulaidongfeng: Patch Set 2: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/538721. |
Message from Go LUCI: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-02-02T01:42:40Z","revision":"5173c11a2b14aaa2325bed1b6047162be5669819"} Please don’t reply on this GitHub thread. Visit golang.org/cl/538721. |
Message from qiulaidongfeng: Patch Set 2: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/538721. |
Message from Go LUCI: Patch Set 2: This CL has failed the run. Reason: Tryjob golang/try/x_tools-gotip-linux-amd64 has failed with summary (view all results): FAILURE
Error: Links: Please don’t reply on this GitHub thread. Visit golang.org/cl/538721. |
Message from Go LUCI: Patch Set 2: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/538721. |
938ea8a
to
1aa99a2
Compare
This PR (HEAD: 1aa99a2) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/538721. Important tips:
|
Message from kyose chang: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/538721. |
Message from qiulaidongfeng: Patch Set 3: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/538721. |
Message from Go LUCI: Patch Set 3: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-02-02T07:21:57Z","revision":"bd4ba790c87d94fb189ef1bd4372d16c972ac8de"} Please don’t reply on this GitHub thread. Visit golang.org/cl/538721. |
Message from qiulaidongfeng: Patch Set 3: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/538721. |
Message from Go LUCI: Patch Set 3: This CL has failed the run. Reason: Tryjob golang/try/gotip-windows-386 has failed with summary (view all results): FAILURE
Tests failed. See all test results. Error: Links:
Please don’t reply on this GitHub thread. Visit golang.org/cl/538721. |
Message from Go LUCI: Patch Set 3: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/538721. |
Message from kyose chang: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/538721. |
Message from qiulaidongfeng: Patch Set 3: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/538721. |
Message from Gopher Robot: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/538721. |
Message from Gopher Robot: Patch Set 3: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/538721. |
Message from kyose chang: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/538721. |
1aa99a2
to
531084d
Compare
This PR (HEAD: 531084d) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/538721. Important tips:
|
Message from kyose chang: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/538721. |
The new code does not need a for-loop and is easier to read.
531084d
to
b3ee265
Compare
This PR (HEAD: b3ee265) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/538721. Important tips:
|
Message from kyose chang: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/538721. |
Message from Keith Randall: Patch Set 5: Auto-Submit+1 Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/538721. |
Message from Keith Randall: Patch Set 5: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/538721. |
Message from kyose chang: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/538721. |
Message from Ian Lance Taylor: Patch Set 5: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/538721. |
Message from Go LUCI: Patch Set 5: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-03-27T19:51:25Z","revision":"5bc5d2d45321dc73bb2b0d22ad03e81b5d15d02e"} Please don’t reply on this GitHub thread. Visit golang.org/cl/538721. |
Message from Ian Lance Taylor: Patch Set 5: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/538721. |
Message from Go LUCI: Patch Set 5: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/538721. |
Message from Go LUCI: Patch Set 5: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/538721. |
The new code does not need a for-loop and is easier to read. Change-Id: Ic182d63c4779c2179b721fcfaec362681284cc16 GitHub-Last-Rev: b3ee265 GitHub-Pull-Request: #63879 Reviewed-on: https://go-review.googlesource.com/c/go/+/538721 Auto-Submit: Keith Randall <khr@golang.org> Reviewed-by: Keith Randall <khr@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Keith Randall <khr@google.com> Reviewed-by: Than McIntosh <thanm@google.com>
This PR is being closed because golang.org/cl/538721 has been merged. |
The new code does not need a for-loop and is easier to read.