Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: PanicNilError error string should have "runtime error: " prefix [1.21 backport] #63815

Closed
gopherbot opened this issue Oct 29, 2023 · 2 comments
Closed

runtime: PanicNilError error string should have "runtime error: " prefix [1.21 backport] #63815

gopherbot opened this issue Oct 29, 2023 · 2 comments
Labels
CherryPickCandidate Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime. WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Milestone
Go1.21.10

Comments

@gopherbot
Copy link

@mauri870 requested issue #63813 to be considered for backport to the next 1.21 minor release.

@gopherbot please open a backport issue for Go 1.21.

Errors that implement runtime.Error should have a "runtime error: " prefix, with the solo exception of runtime.plainError on purpose. Calling panic(nil) results in a PanicNilError that violates this constraint.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Oct 29, 2023
@gopherbot gopherbot mentioned this issue Oct 29, 2023
Open
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Oct 29, 2023
@gopherbot gopherbot added this to the Go1.21.4 milestone Oct 29, 2023
@cherrymui
Copy link
Member

Waiting for the decision of #63813

@cherrymui cherrymui added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Nov 1, 2023
@gopherbot gopherbot modified the milestones: Go1.21.4, Go1.21.5 Nov 7, 2023
@gopherbot gopherbot modified the milestones: Go1.21.5, Go1.21.6 Dec 5, 2023
@gopherbot gopherbot modified the milestones: Go1.21.6, Go1.21.7 Jan 9, 2024
@gopherbot gopherbot modified the milestones: Go1.21.7, Go1.21.8 Feb 6, 2024
@gopherbot gopherbot modified the milestones: Go1.21.8, Go1.21.9 Mar 5, 2024
@gopherbot gopherbot modified the milestones: Go1.21.9, Go1.21.10 Apr 3, 2024
@gopherbot
Copy link
Author

Timed out in state WaitingForInfo. Closing.

(I am just a bot, though. Please speak up if this is a mistake or you have the requested information.)

@gopherbot gopherbot closed this as not planned Won't fix, can't repro, duplicate, stale May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickCandidate Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime. WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Projects
None yet
Milestone
Go1.21.10
Development

No branches or pull requests
2 participants
@gopherbot @cherrymui