Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: (recovered) panic in canRemoveParameter #63755

Closed
findleyr opened this issue Oct 26, 2023 · 2 comments
Closed

x/tools/gopls: (recovered) panic in canRemoveParameter #63755

findleyr opened this issue Oct 26, 2023 · 2 comments
Assignees
@findleyr
Labels
gopls/telemetry-wins gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.14.1

Comments

@findleyr
Copy link
Contributor

findleyr commented Oct 26, 2023 •
edited by adonovan

Found via telemetry: https://storage.googleapis.com/prod-telemetry-merged/2023-10-25.json

Also: vf_9ow

There's a panic in lsp.canRemoveParameter: inspecting nil function bodies (as is the case for external functions) leads to a panic.

Fix incoming.
@findleyr findleyr added gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository. gopls/telemetry-wins labels Oct 26, 2023
@gopherbot gopherbot added this to the Unreleased milestone Oct 26, 2023
@gopherbot
Copy link

Change https://go.dev/cl/537878 mentions this issue: gopls/internal/lsp: fix code action panic on params of external funcs

@findleyr findleyr modified the milestones: Unreleased, gopls/v0.14.1 Oct 26, 2023
@gopherbot
Copy link

Change https://go.dev/cl/537879 mentions this issue: [gopls-release-branch.0.14] gopls/internal/lsp: fix code action panic on params of external funcs

@findleyr findleyr self-assigned this Oct 26, 2023
gopherbot pushed a commit to golang/tools that referenced this issue Oct 26, 2023
@findleyr
[gopls-release-branch.0.14] gopls/internal/lsp: fix code action panic…
8b5abd4 
… on params of external funcs

Fix a panic when inspecting a nil function body.

Fixes golang/go#63755

Change-Id: I39342902b44192dd373dfdb24947079b40dbe115
Reviewed-on: https://go-review.googlesource.com/c/tools/+/537878
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Alan Donovan <adonovan@google.com>
(cherry picked from commit 080c202)
Reviewed-on: https://go-review.googlesource.com/c/tools/+/537879
Auto-Submit: Robert Findley <rfindley@google.com>
Reviewed-by: Peter Weinberger <pjw@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@findleyr findleyr

Labels
gopls/telemetry-wins gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.14.1
Development

No branches or pull requests
2 participants
@gopherbot @findleyr