Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/golangbuild: tip CL build succeeded despite x_tools-gotip-linux-amd64 failing #63753

Closed
dmitshur opened this issue Oct 26, 2023 · 1 comment
Closed

x/build/cmd/golangbuild: tip CL build succeeded despite x_tools-gotip-linux-amd64 failing #63753

dmitshur opened this issue Oct 26, 2023 · 1 comment
Assignees
@mknyszek
Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Oct 26, 2023 •
edited

LUCI trybots were triggered on patch set 9 of CL 502500 and reported "This CL has passed the run" with a LUCI-TryBot-Result+1 vote, despite the x_tools-gotip-linux-amd64 builder failing on patch set 9.

Perhaps there's something about the x_tools- builder we misconfigured that's causing it to be treated as an optional builder rather a required one, or something else happened. This is a tracking issue to investigate.

CC @golang/release, @mknyszek.
@dmitshur dmitshur added Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Oct 26, 2023
@dmitshur dmitshur added this to the Unreleased milestone Oct 26, 2023
@dmitshur dmitshur assigned dmitshur and mknyszek and unassigned dmitshur Oct 26, 2023
@gopherbot
Copy link

Change https://go.dev/cl/537895 mentions this issue: main.star: make x/tools linux-amd64 presubmit for 'go' a tryjob_verifier

gopherbot pushed a commit to golang/build that referenced this issue Oct 26, 2023
@mknyszek
main.star: make x/tools linux-amd64 presubmit for 'go' a tryjob_verifier
767a138 
Currently the x/tools linux-amd64 builder at presubmit for the main Go
repository is triggered indirectly by the linux/amd64 builder. This is
an optimization to prevent wasting resources building the Go toolchain
again.

However, this just impacts resource use and not build latency, so it
doesn't matter too much. And the state of things today means that CV
won't correctly mark a build as failing if just x/tools fails. There may
be a way to dynamically add the x/tools builder to CV's try set, but for
now just do this, which we know will work.

Fixes golang/go#63753.

Change-Id: I6a3ef4fddcdce0c322e9f91fc0f6e3a39989bf25
Reviewed-on: https://go-review.googlesource.com/c/build/+/537895
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
TryBot-Bypass: Michael Knyszek <mknyszek@google.com>
@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mknyszek mknyszek

Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Release
Archived in project
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@mknyszek @dmitshur @gopherbot