Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: narrow file watching to active modules when go.work is in use #63742

Closed
findleyr opened this issue Oct 25, 2023 · 1 comment
Closed

x/tools/gopls: narrow file watching to active modules when go.work is in use #63742

findleyr opened this issue Oct 25, 2023 · 1 comment
Assignees
@findleyr
Labels
gopls/metadata Issues related to metadata loading in gopls gopls/performance Issues related to gopls performance (CPU, memory, etc). gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.15.0

Comments

@findleyr
Copy link
Contributor

Following up on #63536 (comment), we should consider narrowing the watch patterns requested by gopls when a go.work file is in use (or when the view is narrowed to a single module).

For example, with a go.work file we could just watch the go.work file itself, and all main modules. This could significantly improve file watching performance in monorepos.
@findleyr findleyr added gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository. gopls/performance Issues related to gopls performance (CPU, memory, etc). gopls/metadata Issues related to metadata loading in gopls labels Oct 25, 2023
@findleyr findleyr added this to the gopls/v0.15.0 milestone Oct 25, 2023
@findleyr findleyr mentioned this issue Oct 25, 2023
Open
@gopherbot
Copy link

Change https://go.dev/cl/550075 mentions this issue: gopls/internal/lsp/cache: reconcile view modes and workspace packages

@findleyr findleyr self-assigned this Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@findleyr findleyr

Labels
gopls/metadata Issues related to metadata loading in gopls gopls/performance Issues related to gopls performance (CPU, memory, etc). gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.15.0
Development

No branches or pull requests
2 participants
@gopherbot @findleyr