Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile/internal/test: timeouts in TestPGOHash #63733

Closed
gopherbot opened this issue Oct 25, 2023 · 2 comments
Closed

cmd/compile/internal/test: timeouts in TestPGOHash #63733

gopherbot opened this issue Oct 25, 2023 · 2 comments
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.

Comments

@gopherbot
Copy link

gopherbot commented Oct 25, 2023 •
edited by bcmills 

#!watchflakes
post <- pkg == "cmd/compile/internal/test" && test == "TestPGOHash" && `test timed out`

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestPGOHash (44.52s)
    exec.go:190: test timed out while running command: /tmp/workdir-host-ios-arm64-corellium-ios/go/bin/go test -c -o /tmp/workdir-host-ios-arm64-corellium-ios/tmp/TestPGOHash3973003015/001/test.exe -gcflags=-pgoprofile=/tmp/workdir-host-ios-arm64-corellium-ios/tmp/TestPGOHash3973003015/001/inline_hot.pprof -d=pgoinlinebudget=160,pgoinlinecdfthreshold=90,pgodebug=1,,pgohash=v1 -trimpath
    pgo_inl_test.go:39: build failed: exit status 2, output:
        SIGQUIT: quit
        PC=0x1bf5ef374 m=0 sigcode=1

        r0      0xef67
        r1      0x130212bd4
        r2      0x0
        r3      0x1301ba240
...
        r24     0x729d2d67c1821316
        r25     0xbb44e2ea99febd9c
        r26     0x0
        r27     0x838
        r28     0x1030a9380
        r29     0x16d7ceee8
        lr      0x1026a4048
        sp      0x16d7ceee0
        pc      0x1bf5ef374
        fault   0x1bf5ef374

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Oct 25, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "cmd/compile/internal/test" && test == "TestPGOHash"
2023-10-13 22:57 ios-arm64-corellium go@34f2365d cmd/compile/internal/test.TestPGOHash (log) 
--- FAIL: TestPGOHash (44.52s)
    exec.go:190: test timed out while running command: /tmp/workdir-host-ios-arm64-corellium-ios/go/bin/go test -c -o /tmp/workdir-host-ios-arm64-corellium-ios/tmp/TestPGOHash3973003015/001/test.exe -gcflags=-pgoprofile=/tmp/workdir-host-ios-arm64-corellium-ios/tmp/TestPGOHash3973003015/001/inline_hot.pprof -d=pgoinlinebudget=160,pgoinlinecdfthreshold=90,pgodebug=1,,pgohash=v1 -trimpath
    pgo_inl_test.go:39: build failed: exit status 2, output:
        SIGQUIT: quit
        PC=0x1bf5ef374 m=0 sigcode=1

        r0      0xef67
        r1      0x130212bd4
        r2      0x0
        r3      0x1301ba240
...
        r24     0x729d2d67c1821316
        r25     0xbb44e2ea99febd9c
        r26     0x0
        r27     0x838
        r28     0x1030a9380
        r29     0x16d7ceee8
        lr      0x1026a4048
        sp      0x16d7ceee0
        pc      0x1bf5ef374
        fault   0x1bf5ef374

— watchflakes

@bcmills bcmills added the compiler/runtime Issues related to the Go compiler and/or runtime. label Oct 25, 2023
@bcmills bcmills changed the title cmd/compile/internal/test: TestPGOHash failures cmd/compile/internal/test: timeouts in TestPGOHash Oct 25, 2023
@gopherbot
Copy link
Author

Change https://go.dev/cl/535915 mentions this issue: cmd/compile: rework TestPGOHash to not rebuild dependencies

qiulaidongfeng pushed a commit to qiulaidongfeng/go that referenced this issue Oct 31, 2023
@cherrymui @qiulaidongfeng
cmd/compile: rework TestPGOHash to not rebuild dependencies
2f9b099 
TestPGOHash may rebuild dependencies as we pass -trimpath to the
go command. This CL makes it pass -trimpath compiler flag to only
the current package instead, as we only need the current package
to have a stable source file path.

Also refactor buildPGOInliningTest to only take compiler flags,
not go flags, to avoid accidental rebuild.

Should fix golang#63733.

Change-Id: Iec6c4e90cf659790e21083ee2e697f518234c5b9
Reviewed-on: https://go-review.googlesource.com/c/go/+/535915
Reviewed-by: Michael Pratt <mpratt@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Test Flakes
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bcmills @gopherbot