Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/rpc: log spam. #6367

Closed
hanwen opened this issue Sep 11, 2013 · 3 comments
Closed

net/rpc: log spam. #6367

hanwen opened this issue Sep 11, 2013 · 3 comments

Comments

@hanwen
Copy link
Contributor

hanwen commented Sep 11, 2013

consider

 http://golang.org/src/pkg/net/rpc/client.go#L164

this prints to stderr in case of error, and there is no way to suppress this. 

In my scenario, a command-line program serves RPC to a daemon, and it is normal for the
command line program to be interrupted with ^C . When this happens, I get spurious error
output, eg.  

2013/09/11 17:52:48 rpc: client protocol error: unexpected EOF
2013/09/11 17:52:48 rpc: writing response: write unix : broken pipe

How about a 

  rpc.SetLog(interface { Println(interface{}...)})

method to control the RPC logging?

This is with Linux gc,

 changeset:   17988:a71616f65cb1
@rsc
Copy link
Contributor

rsc commented Sep 11, 2013

Comment 1:

we should just delete those log messages. send a CL.

@robpike
Copy link
Contributor

robpike commented Sep 13, 2013

Comment 2:

Status changed to Started.

@robpike
Copy link
Contributor

robpike commented Sep 16, 2013

Comment 3:

This issue was closed by revision ab578e1.

Status changed to Fixed.

@golang golang locked and limited conversation to collaborators Jun 25, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants