Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: redundant import name added by inlining #63613

Closed
findleyr opened this issue Oct 18, 2023 · 2 comments
Closed

x/tools/gopls: redundant import name added by inlining #63613

findleyr opened this issue Oct 18, 2023 · 2 comments
Assignees
@findleyr
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.14.0

Comments

@findleyr
Copy link
Contributor

findleyr commented Oct 18, 2023 •
edited

When an import is added by inlining, it looks like it includes a redundant package name (e.g. os "os"). While this is harmless, we should fix this before the v0.14.0 release as it's pretty noticeable.

CC @adonovan
@findleyr findleyr added gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository. labels Oct 18, 2023
@findleyr findleyr added this to the gopls/v0.14.0 milestone Oct 18, 2023
@findleyr findleyr self-assigned this Oct 18, 2023
@findleyr
Copy link
Contributor Author

(I'll fix this)

@robpike robpike changed the title x/tools/gopls: redundant import name added by inining x/tools/gopls: redundant import name added by inlining Oct 19, 2023
@gopherbot
Copy link

Change https://go.dev/cl/536755 mentions this issue: internal/refactor/inline: avoid redundant import names added by inlining

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@findleyr findleyr

Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.14.0
Development

No branches or pull requests
2 participants
@gopherbot @findleyr