Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/cgo/internal/testfortran: FAIL: TestFortran #63588

Closed
aimuz opened this issue Oct 17, 2023 · 1 comment
Closed

cmd/cgo/internal/testfortran: FAIL: TestFortran #63588

aimuz opened this issue Oct 17, 2023 · 1 comment

Comments

@aimuz
Copy link
Contributor

aimuz commented Oct 17, 2023 •
edited

What version of Go are you using (go version)?

$ go version
go version devel go1.22-5873bd1d7e Mon Oct 16 03:29:27 2023 +0000 darwin/amd64

Does this issue reproduce with the latest release?

yes

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE='auto'
GOARCH='amd64'
GOBIN=''
GOCACHE='/Users/home/Library/Caches/go-build'
GOENV='/Users/home/Library/Application Support/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFLAGS=' -mod=mod'
GOHOSTARCH='amd64'
GOHOSTOS='darwin'
GOINSECURE=''
GOMODCACHE='/Users/home/go/pkg/mod'
GONOPROXY=''
GONOSUMDB=''
GOOS='darwin'
GOPATH='/Users/home/go'
GOPRIVATE=''
GOPROXY='https://goproxy.dev,https://goproxy.io,https://goproxy.cn,direct'
GOROOT='/Users/home/workspace/go'
GOSUMDB='sum.golang.google.cn'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/Users/home/workspace/go/pkg/tool/darwin_amd64'
GOVCS=''
GOVERSION='devel go1.22-5873bd1d7e Mon Oct 16 03:29:27 2023 +0000'
GCCGO='gccgo'
GOAMD64='v1'
AR='ar'
CC='clang'
CXX='clang++'
CGO_ENABLED='1'
GOMOD=''
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -arch x86_64 -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -ffile-prefix-map=/var/folders/pt/qtn3qrvs6n9b_944ggd01nj00000gn/T/go-build2574071897=/tmp/go-build -gno-record-gcc-switches -fno-common'

What did you do?

run ./all.bash Use cases with test failures occur

ref: #63135

Should TestFortran ignore the xcode warnings now that the test case won't pass? Or is there a better way

os version: 14.0 (23A344)

--- FAIL: TestFortran (3.26s)
    fortran_test.go:64: CGO_LDFLAGS= -L /usr/local/Cellar/gcc/13.2.0/lib/gcc/current -Wl,-rpath,/usr/local/Cellar/gcc/13.2.0/lib/gcc/current
    fortran_test.go:71: /usr/local/bin/gfortran [testdata/helloworld/helloworld.f90 -o /dev/null]
    fortran_test.go:77: go run ./testdata/testprog
    fortran_test.go:83: expected ok
        Output:
        # cmd/cgo/internal/testfortran/testdata/testprog
        ld: warning: duplicate -rpath '/usr/local/Cellar/gcc/13.2.0/lib/gcc/current' ignored
        ok
FAIL
FAIL    cmd/cgo/internal/testfortran    5.780s

What did you expect to see?

Unit Test Success

What did you see instead?
@gopherbot
Copy link

Change https://go.dev/cl/535975 mentions this issue: cmd/cgo/internal/testfortran: relaxing test output

yunginnanet pushed a commit to yunginnanet/go that referenced this issue Oct 20, 2023
@cuonglm @yunginnanet
cmd/cgo/internal/testfortran: relax test output
4a03fda 
Some new linker may emit warning message to standard error, causing
false positive in test result.

Fixing this by testing only stdout output.

Fixes golang#63588

Change-Id: I272048c41dc1c316f44af2dfc903bb03383baea3
Reviewed-on: https://go-review.googlesource.com/c/go/+/535975
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
Auto-Submit: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gopherbot @aimuz