Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/sys/unix: update openbsd to OpenBSD 7.4 #63569

Open
mauri870 opened this issue Oct 16, 2023 · 4 comments
Open

x/sys/unix: update openbsd to OpenBSD 7.4 #63569

mauri870 opened this issue Oct 16, 2023 · 4 comments
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone

Comments

@mauri870
Copy link
Member

mauri870 commented Oct 16, 2023

OpenBSD 7.4 is now released

I'm not sure if there is any issues with this release, but as far as I know all the necessary files can be autogerated with mkall.sh in a openbsd 7.4 system.

e.g GOOS=openbsd ./mkall.sh

@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Oct 16, 2023
@gopherbot gopherbot added this to the Unreleased milestone Oct 16, 2023
@cagedmantis cagedmantis added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Oct 16, 2023
@cagedmantis
Copy link
Contributor

cc @golang/runtime

@gopherbot
Copy link

Change https://go.dev/cl/537355 mentions this issue: unix: require minimum OpenBSD 6.4 for pledge, unveil

@4a6f656c
Copy link
Contributor

There should be limited changes since OpenBSD uses libc based system calls.

gopherbot pushed a commit to golang/sys that referenced this issue Oct 31, 2023
OpenBSD 7.3 and 7.4 are the only supported OpenBSD releases.  This change simplifies the version detection and error handling to require at least OpenBSD 6.4 to call the Pledge and Unveil functions.

Updates golang/go#63569.

Change-Id: I6bd0d58807a73a532ddd2d3239687ca19a93db9d
GitHub-Last-Rev: d03d157
GitHub-Pull-Request: #177
Reviewed-on: https://go-review.googlesource.com/c/sys/+/537355
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Joel Sing <joel@sing.id.au>
Reviewed-by: David Chase <drchase@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Reviewed-by: Joel Sing <joel@sing.id.au>
@gopherbot
Copy link

Change https://go.dev/cl/538995 mentions this issue: unix: use fcntl(2) libc stub on OpenBSD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Development

No branches or pull requests

5 participants