Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: remove the tempModFile setting #63537

Closed
findleyr opened this issue Oct 13, 2023 · 2 comments
Closed

x/tools/gopls: remove the tempModFile setting #63537

findleyr opened this issue Oct 13, 2023 · 2 comments
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.15.0

Comments

@findleyr
Copy link
Contributor

findleyr commented Oct 13, 2023 •
edited

Per the rationale provided in #61970: remove the setting. If you need this setting, please leave a comment explaining why.
@findleyr findleyr added gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository. labels Oct 13, 2023
@findleyr findleyr added this to the gopls/v0.15.0 milestone Oct 13, 2023
@gopherbot
Copy link

Change https://go.dev/cl/542642 mentions this issue: gopls: remove the "tempModFile" setting

@gopherbot
Copy link

Change https://go.dev/cl/542641 mentions this issue: gopls/internal/lsp: simplify mod update commands

gopherbot pushed a commit to golang/tools that referenced this issue Nov 20, 2023
@findleyr
gopls/internal/lsp: simplify mod update commands
3510b4f 
There's no reason not to use a temp modfile for these commands, since
they can instead mutate modfiles via use ApplyEdits.

We should not support two ways to make the same change.

For golang/go#63537

Change-Id: I2f9abbddb544e6cbf4bc2f98efd83c8cba038645
Reviewed-on: https://go-review.googlesource.com/c/tools/+/542641
Reviewed-by: Alan Donovan <adonovan@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.15.0
Development

No branches or pull requests
2 participants
@gopherbot @findleyr