Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: match new language versions for type checking #63472

Closed
findleyr opened this issue Oct 9, 2023 · 2 comments
Closed

x/tools/gopls: match new language versions for type checking #63472

findleyr opened this issue Oct 9, 2023 · 2 comments
Assignees
@adonovan
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.15.0

Comments

@findleyr
Copy link
Contributor

findleyr commented Oct 9, 2023

Just spotted this bug: https://cs.opensource.google/go/x/tools/+/master:gopls/internal/lsp/cache/check.go;l=1490;drc=6de34480a867b1198bb6c910cb77c147e89a6023

We need to update goVersionRx to allow for e.g. go1.21.1. As is, it looks like we'll be setting the wrong language version for the new version strings.
@findleyr findleyr added gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository. labels Oct 9, 2023
@findleyr findleyr added this to the gopls/v0.14.0 milestone Oct 9, 2023
@findleyr
Copy link
Contributor Author

This is harmless until 1.22 comes out, because the default behavior of the type checker is to allow all features.

@findleyr findleyr modified the milestones: gopls/v0.14.0, gopls/v0.14.1 Oct 13, 2023
@findleyr findleyr modified the milestones: gopls/v0.14.2, gopls/v0.15.0 Nov 14, 2023
@gopherbot
Copy link

Change https://go.dev/cl/557215 mentions this issue: gopls/internal/lsp/cache: allow versions of form "go1.2.3"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adonovan adonovan

Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.15.0
Development

No branches or pull requests
3 participants
@adonovan @gopherbot @findleyr