Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fmt: all [*]Print[**] functions should not make heap allocations #63456

Closed
go101 opened this issue Oct 9, 2023 · 2 comments
Closed

fmt: all [*]Print[**] functions should not make heap allocations #63456

go101 opened this issue Oct 9, 2023 · 2 comments

Comments

@go101
Copy link

go101 commented Oct 9, 2023

Go toolchain 1.21 has made reflect.ValueOf not allocate if possible,
so now there should be no obstacles which force the print functions allocate.

(I remembered there is an issue for this, but I couldn't find it now.)
@mateusz834
Copy link
Member

#62653 #8618

@mvdan
Copy link
Member

mvdan commented Oct 9, 2023

Closing as a duplicate of that first issue.

@mvdan mvdan closed this as not planned Won't fix, can't repro, duplicate, stale Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mvdan @mateusz834 @go101