Skip to content

x/telemetry/cmd/gotelemetry: document gotelemetry subcommand flag usage #63421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hyangah opened this issue Oct 6, 2023 · 1 comment
Closed
Labels
Documentation Issues describing a change to documentation. FrozenDueToAge telemetry x/telemetry issues
Milestone

Comments

@hyangah
Copy link
Contributor

hyangah commented Oct 6, 2023

The command structure in cmd/gotelemetry does not yet support subcommand only flags yet.
So, it's a bit hard to reason about.
We eventually want to add some part of it into the go toolchain, so we don't want to invest on this too much yet.

However, let's mention the expected flag locations in the usage doc (gotelemetry help).

All these are invalid usages. :-)

gotelemetry view -h
gotelemetry view -addr=localhost:0
gotelemetry -addr=http://localhost:0 view

@gopherbot gopherbot added the telemetry x/telemetry issues label Oct 6, 2023
@gopherbot gopherbot added this to the Unreleased milestone Oct 6, 2023
@gopherbot gopherbot added the Documentation Issues describing a change to documentation. label Oct 6, 2023
@hyangah
Copy link
Contributor Author

hyangah commented Oct 6, 2023

Sorry for the noise. My workspace was outdated.

@hyangah hyangah closed this as completed Oct 6, 2023
@golang golang locked and limited conversation to collaborators Oct 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Documentation Issues describing a change to documentation. FrozenDueToAge telemetry x/telemetry issues
Projects
None yet
Development

No branches or pull requests

2 participants