Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/telemetry/internal/upload: bucket,histogram counters in config are not recognized #63416

Closed
hyangah opened this issue Oct 6, 2023 · 1 comment
Closed

x/telemetry/internal/upload: bucket,histogram counters in config are not recognized #63416

hyangah opened this issue Oct 6, 2023 · 1 comment
Assignees
@pjweinb
Labels
FrozenDueToAge telemetry x/telemetry issues
Milestone
gopls/v0.14.0

Comments

@hyangah
Copy link
Contributor

hyangah commented Oct 6, 2023

Bucket, histogram counters config can have format like

gopls/client:{vscode,vscodium,vscode-insiders,code-server,eglot,govim,neovim,coc.nvim,sublimetext,other}
gopls/goversion:{1.16,1.17,1.18,1.19,1.20,1.21,1.22,1.23,1.24,1.25,1.26,1.27,1.28,1.29,1.30}

Current upload logic doesn't understand it.

https://go.googlesource.com/telemetry/+/fc2106bd9d7a/internal/upload/reports.go#197
@gopherbot gopherbot added the telemetry x/telemetry issues label Oct 6, 2023
@gopherbot gopherbot added this to the Unreleased milestone Oct 6, 2023
@hyangah hyangah modified the milestones: Unreleased, gopls/v0.14.0 Oct 6, 2023
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/533259 mentions this issue: internal/upload: expand counter name patterns

@golang golang locked and limited conversation to collaborators Oct 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pjweinb pjweinb

Labels
FrozenDueToAge telemetry x/telemetry issues
Projects
None yet
Milestone
gopls/v0.14.0
Development

No branches or pull requests
3 participants
@hyangah @pjweinb @gopherbot