Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: verify support for workspace vendoring #63375

Closed
findleyr opened this issue Oct 4, 2023 · 2 comments
Closed

x/tools/gopls: verify support for workspace vendoring #63375

findleyr opened this issue Oct 4, 2023 · 2 comments
Assignees
@findleyr
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.15.0

Comments

@findleyr
Copy link
Contributor

findleyr commented Oct 4, 2023 •
edited

https://go.dev/issue/60056 is adding support for workspace vendoring.

This is likely to work out-of-the-box since gopls relies on go list for package information. However, we'll need to verify that this works well and include additional regression tests for the new workspace layout.

We may want to add code lenses to update the vendor directory.
@findleyr findleyr added gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository. labels Oct 4, 2023
@findleyr findleyr added this to the gopls/v0.15.0 milestone Oct 4, 2023
@findleyr findleyr self-assigned this Feb 2, 2024
@gopherbot
Copy link

Change https://go.dev/cl/560466 mentions this issue: gopls/internal/cache: support workspace vendoring

@gopherbot
Copy link

Change https://go.dev/cl/560717 mentions this issue: gopls/internal/cache: detect and reinit on workspace vendor changes

gopherbot pushed a commit to golang/tools that referenced this issue Feb 2, 2024
@findleyr
gopls/internal/cache: support workspace vendoring
aecdb2d 
Support workspace vendoring by simply removing logic in gopls for
deriving the `-mod` flag. If we don't need to set `-mod=mod`, let the go
command decide what to do. We don't need to worry about explicitly
setting `-mod=readonly`, since this has been the default since Go 1.16.

For golang/go#63375

Change-Id: I1adbe20cef5b9e3edcb7ac2445c4d5ae63f3a3a9
Reviewed-on: https://go-review.googlesource.com/c/tools/+/560466
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Alan Donovan <adonovan@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@findleyr findleyr

Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.15.0
Development

No branches or pull requests
2 participants
@gopherbot @findleyr