-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/tools/go/ssa: add support for new loop variable scoping #63374
Labels
FrozenDueToAge
okay-after-rc1
Used by release team to mark a release-blocker issue as okay to resolve either before or after rc1
release-blocker
Tools
This label describes issues relating to any tools in the x/tools repository.
Milestone
Comments
Change https://go.dev/cl/533056 mentions this issue: |
Change https://go.dev/cl/533239 mentions this issue: |
Change https://go.dev/cl/535375 mentions this issue: |
gopherbot
pushed a commit
to golang/tools
that referenced
this issue
Oct 16, 2023
Propagate goversions on functions and initializers. Updates golang/go#63374 Change-Id: I67b25b65fd83888fa27818aee3570b8bf4c09508 Reviewed-on: https://go-review.googlesource.com/c/tools/+/533239 TryBot-Result: Gopher Robot <gobot@golang.org> Run-TryBot: Tim King <taking@google.com> Reviewed-by: Alan Donovan <adonovan@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
gopherbot
pushed a commit
to golang/tools
that referenced
this issue
Oct 25, 2023
Adds support for the new *ast.RangeStmt semantics based on the goversion. Updates golang/go#63374 Change-Id: I938be38fd1d190057ef585f9bd1cb9eb54f0e081 Reviewed-on: https://go-review.googlesource.com/c/tools/+/535375 Run-TryBot: Tim King <taking@google.com> Reviewed-by: Alan Donovan <adonovan@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> TryBot-Result: Gopher Robot <gobot@golang.org>
Change https://go.dev/cl/538055 mentions this issue: |
gopherbot
pushed a commit
to golang/tools
that referenced
this issue
Nov 10, 2023
Adds a new versions package to provide x/tools a way to deal with new GoVersion() and FileVersions API from go/types and the new go/version standard library. This provides a stable API until 1.26. Updates golang/go#63374 Updates golang/go#62605 Change-Id: I4de54df00ea0f4363c0383cbdc917186277bfd0a Reviewed-on: https://go-review.googlesource.com/c/tools/+/533056 Run-TryBot: Tim King <taking@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Alan Donovan <adonovan@google.com> TryBot-Result: Gopher Robot <gobot@golang.org>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
FrozenDueToAge
okay-after-rc1
Used by release team to mark a release-blocker issue as okay to resolve either before or after rc1
release-blocker
Tools
This label describes issues relating to any tools in the x/tools repository.
This issue tracks support in x/tools/go/ssa for the new loop variable scoping rules of https://go.dev/issue/60078, available now behind GOEXPERIMENT=loopvar and likely on for language versions >= 1.22.
Marking as a release blocker because we endeavor to keep our tools in sync with language changes.
The text was updated successfully, but these errors were encountered: