Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go/types, x/tools/go/ssa: panic: type param without replacement encountered [1.21 backport] #63339

Closed
gopherbot opened this issue Oct 2, 2023 · 6 comments
Closed

go/types, x/tools/go/ssa: panic: type param without replacement encountered [1.21 backport] #63339

gopherbot opened this issue Oct 2, 2023 · 6 comments
Assignees
@griesemer
Labels
CherryPickApproved Used during the release process for point releases release-blocker Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Go1.21.4

Comments

@gopherbot
Copy link

@griesemer requested issue #63260 to be considered for backport to the next 1.21 minor release.

@gopherbot please consider this for backport to 1.21.3. This is a type-checker bug.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Oct 2, 2023
@gopherbot gopherbot mentioned this issue Oct 2, 2023
Closed
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Oct 2, 2023
@gopherbot gopherbot modified the milestones: Unreleased, Go1.21.2 Oct 2, 2023
@griesemer griesemer self-assigned this Oct 2, 2023
@dmitshur dmitshur modified the milestones: Go1.21.2, Go1.21.3 Oct 2, 2023
@dmitshur
Copy link
Contributor

dmitshur commented Oct 2, 2023

The release-blocker here is inherited from the upstream issue (#63260 (comment) + #63260 (comment)). (CC @findleyr.)

@dmitshur dmitshur changed the title x/tools/go/ssa: panic: type param without replacement encountered [1.21 backport] go/types, x/tools/go/ssa: panic: type param without replacement encountered [1.21 backport] Oct 2, 2023
@gopherbot
Copy link
Author

Change https://go.dev/cl/531998 mentions this issue: [release-branch.go1.21] go/types, types2: don't implicitly modify an argument function's type

@prattmic prattmic added the CherryPickApproved Used during the release process for point releases label Oct 4, 2023
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Oct 4, 2023
@dmitshur dmitshur modified the milestones: Go1.21.3, Go1.21.4 Oct 10, 2023
gopherbot pushed a commit that referenced this issue Oct 12, 2023
@griesemer @gopherbot
[release-branch.go1.21] go/types, types2: don't implicitly modify an …
bae0152 
…argument function's type

See the comment in the (very small) fix for a detailed description.
Use the opportunity to introduce a generic clone function which may
be useful elsewhere.

Fixes #63339.

Change-Id: Ic63c6b8bc443011b1a201908254f7d062e1aec71
Reviewed-on: https://go-review.googlesource.com/c/go/+/532157
Run-TryBot: Robert Griesemer <gri@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>
Reviewed-by: Robert Griesemer <gri@google.com>
Auto-Submit: Robert Griesemer <gri@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-on: https://go-review.googlesource.com/c/go/+/531998
Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
@gopherbot
Copy link
Author

Closed by merging bae0152 to release-branch.go1.21.

@gopherbot
Copy link
Author

Change https://go.dev/cl/534917 mentions this issue: [release-branch.go1.21] go/types, types2: use a non-generic clone helper

@gopherbot
Copy link
Author

Change https://go.dev/cl/535055 mentions this issue: [release-branch.go1.21] go/types, types2: don't use generics

@gopherbot
Copy link
Author

Change https://go.dev/cl/535135 mentions this issue: [release-branch.go1.21] go/types, types2: don't use generics

gopherbot pushed a commit that referenced this issue Oct 13, 2023
@griesemer @gopherbot
[release-branch.go1.21] go/types, types2: don't use generics
64b6c48 
This fixes cherry-pick CL 531998.

For #63339.

Change-Id: I6dac0909ca85d68684ce36025284d25db32e0b15
Reviewed-on: https://go-review.googlesource.com/c/go/+/535135
Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Alan Donovan <adonovan@google.com>
awly pushed a commit to tailscale/go that referenced this issue Feb 7, 2024
@griesemer @awly
[release-branch.go1.21] go/types, types2: don't use generics
5a631c0 
This fixes cherry-pick CL 531998.

For golang#63339.

Change-Id: I6dac0909ca85d68684ce36025284d25db32e0b15
Reviewed-on: https://go-review.googlesource.com/c/go/+/535135
Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Alan Donovan <adonovan@google.com>
JanDeDobbeleer pushed a commit to JanDeDobbeleer/go that referenced this issue Feb 12, 2024
@griesemer @JanDeDobbeleer
[release-branch.go1.21] go/types, types2: don't use generics
75be12d 
This fixes cherry-pick CL 531998.

For golang#63339.

Change-Id: I6dac0909ca85d68684ce36025284d25db32e0b15
Reviewed-on: https://go-review.googlesource.com/c/go/+/535135
Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Alan Donovan <adonovan@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@griesemer griesemer

Labels
CherryPickApproved Used during the release process for point releases release-blocker Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Go1.21.4
Development

No branches or pull requests
4 participants
@prattmic @dmitshur @griesemer @gopherbot