Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/link: split text sections for arm 32-bit (tracking issue) [1.21 backport] #63317

Closed
gopherbot opened this issue Sep 30, 2023 · 2 comments
Closed
Labels
CherryPickApproved Used during the release process for point releases
Milestone

Comments

@gopherbot
Copy link

@thanm requested issue #63315 to be considered for backport to the next 1.21 minor release.

@gopherbot please open backport issues

@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Sep 30, 2023
@gopherbot gopherbot added this to the Go1.21.2 milestone Sep 30, 2023
@gopherbot
Copy link
Author

Change https://go.dev/cl/532096 mentions this issue: cmd/link: split text sections for arm 32-bit

@prattmic prattmic added the CherryPickApproved Used during the release process for point releases label Oct 4, 2023
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Oct 4, 2023
@gopherbot gopherbot modified the milestones: Go1.21.2, Go1.21.3, Go1.21.4 Oct 5, 2023
@gopherbot
Copy link
Author

Closed by merging 236c07c to release-branch.go1.21.

gopherbot pushed a commit that referenced this issue Oct 12, 2023
This CL is a roll-forward (tweaked slightly) of CL 467715, which
turned on text section splitting for GOARCH=arm. The intent is to
avoid recurrent problems with external linking where there is a
disagreement between the Go linker and the external linker over
whether a given branch will reach. In the past our approach has been
to tweak the reachability calculations slightly to try to work around
potential linker problems, but this hasn't proven to be very robust;
section splitting seems to offer a better long term fix.

Updates #58425.
Fixes #63317.

Change-Id: I7372d41abce84097906a3d0805b6b9c486f345d6
Reviewed-on: https://go-review.googlesource.com/c/go/+/531795
Reviewed-by: Cherry Mui <cherryyz@google.com>
Run-TryBot: Than McIntosh <thanm@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
(cherry picked from commit 1e69040)
Reviewed-on: https://go-review.googlesource.com/c/go/+/532096
Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CherryPickApproved Used during the release process for point releases
Projects
None yet
Development

No branches or pull requests

2 participants