Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: less syntax highlighting in v0.14.0-pre.1 #63291

Closed
erdauletbatalov opened this issue Sep 29, 2023 · 6 comments
Closed

x/tools/gopls: less syntax highlighting in v0.14.0-pre.1 #63291

erdauletbatalov opened this issue Sep 29, 2023 · 6 comments
Assignees
@findleyr
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.14.0

Comments

@erdauletbatalov
Copy link

What version of Go are you using (go version)?

$ go version 1.18

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

go env Output
$ go env

GOARCH="amd64"

What did you do?

Just installed gopls v0.14.0-pre.1 and got this issue

What did you expect to see?

I expect code colorization to work as it was working in go nightly before

What did you see instead?

code colorization feature disapeared

before and after:
photo_2023-09-29_12-56-38
photo_2023-09-29_12-56-31
@erdauletbatalov
Copy link
Author

Also forgot to mention that I checked everything and ended up with concluding that gopls v0.14 is the actual problem causer.

@erdauletbatalov
Copy link
Author

I installed prev version of gopls and code colorization got back

@seankhliao seankhliao changed the title affected/package: gopls v0.14.0-pre.1 code colorization disappeared x/tools/gopls: less syntax highlighting in v0.14.0-pre.1 Sep 29, 2023
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Sep 29, 2023
@gopherbot gopherbot added this to the Unreleased milestone Sep 29, 2023
@findleyr findleyr modified the milestones: Unreleased, gopls/v0.14.0 Oct 3, 2023
@findleyr
Copy link
Contributor

findleyr commented Oct 3, 2023

Thanks very much for the report. We'll look into this and ensure it's fixed before the release.

@hyangah
Copy link
Contributor

hyangah commented Oct 7, 2023 •
edited

the initialize response omits all the necessary legend info.

"semanticTokensProvider":{"legend":{"tokenTypes":[],"tokenModifiers":[]},"range":true,"full":true},

I am guessing this bug is related to the Option management changed in cl/526417

@findleyr
Copy link
Contributor

findleyr commented Oct 9, 2023 •
edited

Thanks for investigating, @hyangah, that must be right. I'll fix.

@findleyr findleyr self-assigned this Oct 9, 2023
@gopherbot
Copy link

Change https://go.dev/cl/533755 mentions this issue: gopls/internal/lsp: use the correct options for semantic tokens legend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@findleyr findleyr

Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.14.0
Development

No branches or pull requests
4 participants
@hyangah @gopherbot @erdauletbatalov @findleyr