Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: extract-method is slow in eglot (but not VS Code) #63286

Open
adonovan opened this issue Sep 28, 2023 · 2 comments
Open

x/tools/gopls: extract-method is slow in eglot (but not VS Code) #63286

adonovan opened this issue Sep 28, 2023 · 2 comments
Assignees
@adonovan
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/backlog

Comments

@adonovan
Copy link
Member

It routinely takes eglot 13s to apply an extract-method fix that is almost instant in VS Code. (This happens even when the ApplyFix downcall has been patched to set async: true.) The server's computation of the diff is fast but the client's application of the diff is slow. Clearly something is amiss in eglot. The task of this issue is to identify the cause and file an upstream bug, because whatever it is likely affects a number of other eglot operations as well.

(For the sake of reproducibility, I was extracting the block at L1175 of the https://go-review.git.corp.google.com/c/tools/+/531695/1/internal/refactor/inline/inline.go.)
@adonovan adonovan self-assigned this Sep 28, 2023
@gopherbot gopherbot added the gopls Issues related to the Go language server, gopls. label Sep 28, 2023
@seankhliao seankhliao changed the title gopls: extract-method is slow in eglot (but not VS Code) x/tools/gopls: extract-method is slow in eglot (but not VS Code) Dec 8, 2023
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Dec 8, 2023
@gopherbot gopherbot added this to the Unreleased milestone Dec 8, 2023
@suzmue suzmue modified the milestones: Unreleased, gopls/v0.15.0 Dec 19, 2023
@findleyr
Copy link
Contributor

findleyr commented Jan 6, 2024

Until there is evidence that this is a gopls bug, I'm going to put this in the backlog.

@findleyr findleyr modified the milestones: gopls/v0.15.0, gopls/backlog Jan 6, 2024
@adonovan
Copy link
Member Author

adonovan commented Jan 6, 2024

Until there is evidence that this is a gopls bug, I'm going to put this in the backlog.

It's not a gopls bug; this issue is just a reminder to follow up with an eglot bug that impairs gopls usability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adonovan adonovan

Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/backlog
Development

No branches or pull requests
4 participants
@adonovan @suzmue @gopherbot @findleyr