Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/internal/task: TestTagTelemetry failures #63258

Closed
gopherbot opened this issue Sep 27, 2023 · 4 comments
Closed

x/build/internal/task: TestTagTelemetry failures #63258

gopherbot opened this issue Sep 27, 2023 · 4 comments
Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@gopherbot
Copy link 

#!watchflakes
default <- pkg == "golang.org/x/build/internal/task" && test == "TestTagTelemetry"

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestTagTelemetry (66.92s)
    --- FAIL: TestTagTelemetry/master_tag (61.93s)
        tagx_test.go:601: task await config CL submission: started
        tagx_test.go:601: task tag if appropriate: started
        tagx_test.go:601: task generate config CL: started
        tagx_test.go:601: task generate config CL: started
        tagx_test.go:623: 2023-09-27 09:23:09.867328 -0400 EDT m=+64.853310138	task generate config CL: LOG: not creating CL: config has not changed
        tagx_test.go:605: task generate config CL: done: 
        tagx_test.go:601: task await config CL submission: started
        tagx_test.go:623: 2023-09-27 09:23:09.867775 -0400 EDT m=+64.853757474	task await config CL submission: LOG: not awaiting: no CL was created
        tagx_test.go:605: task await config CL submission: done: <nil>
        tagx_test.go:601: task tag if appropriate: started
        tagx_test.go:623: 2023-09-27 09:23:13.33363 -0400 EDT m=+68.319611693	task tag if appropriate: LOG: tagging x/telemetry/config at 4f632a348fa06b82a9f19bf5edc60f48992a68e9 as config/v0.3.0
        tagx_test.go:605: task tag if appropriate: done: config/v0.3.0
        tagtelemetry_test.go:110: git command failed: context deadline exceeded, stderr

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Sep 27, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/build/internal/task" && test == "TestTagTelemetry"
2023-09-27 02:35 darwin-amd64-13 build@5d3521b0 go@1a51b59c x/build/internal/task.TestTagTelemetry (log) 
--- FAIL: TestTagTelemetry (66.92s)
    --- FAIL: TestTagTelemetry/master_tag (61.93s)
        tagx_test.go:601: task await config CL submission: started
        tagx_test.go:601: task tag if appropriate: started
        tagx_test.go:601: task generate config CL: started
        tagx_test.go:601: task generate config CL: started
        tagx_test.go:623: 2023-09-27 09:23:09.867328 -0400 EDT m=+64.853310138	task generate config CL: LOG: not creating CL: config has not changed
        tagx_test.go:605: task generate config CL: done: 
        tagx_test.go:601: task await config CL submission: started
        tagx_test.go:623: 2023-09-27 09:23:09.867775 -0400 EDT m=+64.853757474	task await config CL submission: LOG: not awaiting: no CL was created
        tagx_test.go:605: task await config CL submission: done: <nil>
        tagx_test.go:601: task tag if appropriate: started
        tagx_test.go:623: 2023-09-27 09:23:13.33363 -0400 EDT m=+68.319611693	task tag if appropriate: LOG: tagging x/telemetry/config at 4f632a348fa06b82a9f19bf5edc60f48992a68e9 as config/v0.3.0
        tagx_test.go:605: task tag if appropriate: done: config/v0.3.0
        tagtelemetry_test.go:110: git command failed: context deadline exceeded, stderr

— watchflakes

@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Sep 27, 2023
@gopherbot gopherbot added this to the Unreleased milestone Sep 27, 2023
@gopherbot
Copy link
Author

Change https://go.dev/cl/530980 mentions this issue: internal/task: remove arbitrary timeout for TestTagTelemetry

@bcmills
Copy link
Contributor

bcmills commented Sep 27, 2023

This seems likely to be related to #56231.

@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Sep 28, 2023
@gopherbot
Copy link
Author

Change https://go.dev/cl/533098 mentions this issue: internal/task: remove context timeout

gopherbot pushed a commit to golang/build that referenced this issue Oct 5, 2023
@heschi @gopherbot
internal/task: remove context timeout
96b29b7 
Based on what happened in golang/go#63258, I expect that this will "fix" the
problem. Guess we'll see.

Fixes golang/go#56231

Change-Id: Id398720effc6a2de4eb67c56663154b082edb109
Reviewed-on: https://go-review.googlesource.com/c/build/+/533098
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Heschi Kreinick <heschi@google.com>
@bcmills bcmills mentioned this issue Oct 25, 2023
Closed
@bcmills bcmills mentioned this issue Nov 3, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done.
Projects
Test Flakes
Status: Done
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@dmitshur @bcmills @gopherbot