Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build: build broken on windows/386 since CL 504531 #63243

Closed
bcmills opened this issue Sep 26, 2023 · 2 comments
Closed

x/build: build broken on windows/386 since CL 504531 #63243

bcmills opened this issue Sep 26, 2023 · 2 comments
Labels
arch-386 Issues solely affecting the 32-bit x86 architecture Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Windows
Milestone
Unreleased

Comments

@bcmills
Copy link
Contributor

bcmills commented Sep 26, 2023

What did you do?

~/x/build$ GOOS=windows GOARCH=386 go test -c -o /dev/null ./...

What did you expect to see?

All tests build successfully.

What did you see instead?

~/x/build$ GOOS=windows GOARCH=386 go test -c -o /dev/null ./...
go: downloading github.com/tarm/serial v0.0.0-20180830185346-98f6abe2eb07
# github.com/apache/arrow/go/v11/internal/utils
../../pkg/mod/github.com/apache/arrow/go/v11@v11.0.0/internal/utils/transpose_ints_def.go:76:4: undefined: TransposeInt8Int8
../../pkg/mod/github.com/apache/arrow/go/v11@v11.0.0/internal/utils/transpose_ints_def.go:78:4: undefined: TransposeInt8Int16
../../pkg/mod/github.com/apache/arrow/go/v11@v11.0.0/internal/utils/transpose_ints_def.go:80:4: undefined: TransposeInt8Int32
../../pkg/mod/github.com/apache/arrow/go/v11@v11.0.0/internal/utils/transpose_ints_def.go:82:4: undefined: TransposeInt8Int64
../../pkg/mod/github.com/apache/arrow/go/v11@v11.0.0/internal/utils/transpose_ints_def.go:84:4: undefined: TransposeInt8Uint8
../../pkg/mod/github.com/apache/arrow/go/v11@v11.0.0/internal/utils/transpose_ints_def.go:86:4: undefined: TransposeInt8Uint16
../../pkg/mod/github.com/apache/arrow/go/v11@v11.0.0/internal/utils/transpose_ints_def.go:88:4: undefined: TransposeInt8Uint32
../../pkg/mod/github.com/apache/arrow/go/v11@v11.0.0/internal/utils/transpose_ints_def.go:90:4: undefined: TransposeInt8Uint64
../../pkg/mod/github.com/apache/arrow/go/v11@v11.0.0/internal/utils/transpose_ints_def.go:95:4: undefined: TransposeInt16Int8
../../pkg/mod/github.com/apache/arrow/go/v11@v11.0.0/internal/utils/transpose_ints_def.go:97:4: undefined: TransposeInt16Int16
../../pkg/mod/github.com/apache/arrow/go/v11@v11.0.0/internal/utils/transpose_ints_def.go:97:4: too many errors
…
FAIL    golang.org/x/build/cmd/buildstats [build failed]
…
FAIL    golang.org/x/build/internal/buildstats [build failed]

This build break appears to have been introduced in https://go.dev/cl/504531 (attn @cagedmantis @heschi @dmitshur), but was masked on the build dashboard by a combination of a missing builder for this platform on the development branch (#63240) and a lack of watchflakes reporting for persistently-broken builds (#58819).
@bcmills bcmills added OS-Windows NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. arch-386 Issues solely affecting the 32-bit x86 architecture labels Sep 26, 2023
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Sep 26, 2023
@gopherbot gopherbot added this to the Unreleased milestone Sep 26, 2023
This was referenced Sep 26, 2023
Closed
Open
@heschi
Copy link
Contributor

heschi commented Sep 26, 2023

It's not great that this happened by accident. But FWIW I think x/build doesn't need to support all first class ports, since it's internal infrastructure, and I'm fine leaving it broken.

@heschi
Copy link
Contributor

heschi commented Oct 3, 2023

We discussed and are fine leaving it broken. Thanks for pointing it out so we could make an actual decision.

@heschi heschi closed this as completed Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arch-386 Issues solely affecting the 32-bit x86 architecture Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Windows
Projects
Go Release
Archived in project
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@bcmills @gopherbot @heschi