Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build: TryBot and build dashboard missing x-repo coverage for windows/386 #63240

Closed
bcmills opened this issue Sep 26, 2023 · 6 comments
Closed

x/build: TryBot and build dashboard missing x-repo coverage for windows/386 #63240

bcmills opened this issue Sep 26, 2023 · 6 comments
Assignees
@prattmic
Labels
arch-386 Issues solely affecting the 32-bit x86 architecture Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. OS-Windows
Milestone
Unreleased

Comments

@bcmills
Copy link
Contributor

bcmills commented Sep 26, 2023 •
edited

What did you do?

Look at the build status for the x repos on https://build.golang.org/.

What did you expect to see?

A passing status for each of the x repos for at least all of the first class ports.

What did you see instead?

No status for any x-repo builder for the windows/386 platform on release-branch.go1.21 or the master branch.

It appears that the x-repo configuration for this platform was missed when the windows/386 builder was upgraded to windows-386-2016 in https://go.dev/cl/468937 and https://go.dev/cl/463579.

(attn @dmitshur @prattmic; CC @golang/release @golang/windows)
@bcmills bcmills added OS-Windows Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. Soon This needs to be done soon. (regressions, serious bugs, outages) arch-386 Issues solely affecting the 32-bit x86 architecture labels Sep 26, 2023
@gopherbot gopherbot added this to the Unreleased milestone Sep 26, 2023
@bcmills bcmills mentioned this issue Sep 26, 2023
Closed
@bcmills
Copy link
Contributor Author

bcmills commented Sep 26, 2023 •
edited

This partially masked a build break in the x/build repo (#63243).
As far as I can tell it is not masking any other regressions at the moment.

@heschi
Copy link
Contributor

heschi commented Sep 26, 2023

Huh. When setting up LUCI I didn't realize that this was a mistake. I didn't (and still don't) see much point in supporting 386 on x/build. Most other repos have a windows-386 builder on LUCI and all of those are green.

@bcmills
Copy link
Contributor Author

bcmills commented Sep 26, 2023

I didn't (and still don't) see much point in supporting 386 on x/build.

I agree; it's probably fine to omit windows/386 for x/build in particular.

Most other repos have a windows-386 builder on LUCI and all of those are green.

That's what I would expect given that the other repos are also still passing on the windows-386-2008 builder on release-branch.go1.20 — but I worry about how long they'll stay that way, particularly in the less-frequently-updated repos like term and sync where we don't get many active CLs that would cause us to run LUCI TryBots.

@heschi
Copy link
Contributor

heschi commented Sep 26, 2023

I/we watch https://ci.chromium.org/p/golang too so we're not relying just on TryBots, FWIW.

Anyway, we'll talk it over and either re-enable it or say that we're not worried about it for the remainder of the LUCI migration given that we've already been okay for 7 months. Thanks.

@bcmills bcmills removed the Soon This needs to be done soon. (regressions, serious bugs, outages) label Sep 27, 2023
@heschi
Copy link
Contributor

heschi commented Oct 3, 2023

Seems like it's worth fixing just for all our sanity's sake. @prattmic, can you take this one?

@prattmic prattmic self-assigned this Oct 3, 2023
@gopherbot
Copy link

Change https://go.dev/cl/532376 mentions this issue: dashboard: add windows-386-2016 builders to x repos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prattmic prattmic

Labels
arch-386 Issues solely affecting the 32-bit x86 architecture Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. OS-Windows
Projects
Go Release
Archived in project
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@prattmic @bcmills @gopherbot @heschi