-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/build: TryBot and build dashboard missing x-repo coverage for windows/386 #63240
Comments
This partially masked a build break in the |
Huh. When setting up LUCI I didn't realize that this was a mistake. I didn't (and still don't) see much point in supporting 386 on x/build. Most other repos have a windows-386 builder on LUCI and all of those are green. |
I agree; it's probably fine to omit
That's what I would expect given that the other repos are also still passing on the |
I/we watch https://ci.chromium.org/p/golang too so we're not relying just on TryBots, FWIW. Anyway, we'll talk it over and either re-enable it or say that we're not worried about it for the remainder of the LUCI migration given that we've already been okay for 7 months. Thanks. |
Seems like it's worth fixing just for all our sanity's sake. @prattmic, can you take this one? |
Change https://go.dev/cl/532376 mentions this issue: |
What did you do?
Look at the build status for the
x
repos on https://build.golang.org/.What did you expect to see?
A passing status for each of the
x
repos for at least all of the first class ports.What did you see instead?
No status for any
x
-repo builder for thewindows/386
platform onrelease-branch.go1.21
or themaster
branch.It appears that the x-repo configuration for this platform was missed when the
windows/386
builder was upgraded towindows-386-2016
in https://go.dev/cl/468937 and https://go.dev/cl/463579.(attn @dmitshur @prattmic; CC @golang/release @golang/windows)
The text was updated successfully, but these errors were encountered: