Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/internal/task: nil panic in FakeCloudBuild.RunScript #63239

Closed
bcmills opened this issue Sep 26, 2023 · 3 comments
Closed

x/build/internal/task: nil panic in FakeCloudBuild.RunScript #63239

bcmills opened this issue Sep 26, 2023 · 3 comments
Assignees
@bcmills
Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Unreleased

Comments

@bcmills
Copy link
Contributor

bcmills commented Sep 26, 2023 

#!watchflakes
post <- log ~ `panic: runtime error: invalid memory address or nil pointer dereference` && log ~ `^\s*golang.org/x/build/internal/task\.\(\*FakeCloudBuild\)\.RunScript`

https://build.golang.org/log/0ac850a84bf4831709b3f25e2cd8fefdb085155b:

panic: runtime error: invalid memory address or nil pointer dereference
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x8 pc=0x830ef5b]

goroutine 480 [running]:
golang.org/x/build/internal/task.(*GitDir).Close(...)
	/tmp/buildlet/gopath/src/golang.org/x/build/internal/task/git.go:92
panic({0x86bb140?, 0x8f7fda0?})
	/tmp/buildlet/go/src/runtime/panic.go:765 +0x132
golang.org/x/build/internal/task.(*FakeCloudBuild).RunScript(0xc0007d23c0, {0x8864f58, 0xc000885c80}, {0xc000330400, 0x60}, {0xc000409a96?, 0xc0000cd460?}, {0xc0002d0e00, 0x2, 0x2})
	/tmp/buildlet/gopath/src/golang.org/x/build/internal/task/fakes.go:802 +0x13a
golang.org/x/build/internal/task.(*TagXReposTasks).UpdateGoMod(0xc000818380, 0x68?, {{0xc000409a96, 0x5}, {0xc0005f6948, 0x12}, {0xc0002cef90, 0x2, 0x2}, {0x0, ...}, ...}, ...)
	/tmp/buildlet/gopath/src/golang.org/x/build/internal/task/tagx.go:412 +0x98d
reflect.Value.call({0x86d92e0?, 0xc0002cf2e0?, 0x884eee0?}, {0x8341d15, 0x4}, {0xc000885ce0, 0x4, 0x79244b2?})
	/tmp/buildlet/go/src/reflect/value.go:596 +0xce5
reflect.Value.Call({0x86d92e0?, 0xc0002cf2e0?, 0xc0005a84c0?}, {0xc000885ce0?, 0x884eee0?, 0x7a3a400?})
	/tmp/buildlet/go/src/reflect/value.go:380 +0xb9
golang.org/x/build/internal/workflow.runTask({0x8865310?, 0xc0007d2460?}, {0x70, 0xf7, 0xf4, 0x43, 0xa1, 0x8a, 0x4f, 0xe, ...}, ...)
	/tmp/buildlet/gopath/src/golang.org/x/build/internal/workflow/workflow.go:902 +0x3a7
golang.org/x/build/internal/workflow.(*Workflow).Run.func2()
	/tmp/buildlet/gopath/src/golang.org/x/build/internal/workflow/workflow.go:819 +0xa5
created by golang.org/x/build/internal/workflow.(*Workflow).Run in goroutine 206
	/tmp/buildlet/gopath/src/golang.org/x/build/internal/workflow/workflow.go:819 +0xec5
FAIL	golang.org/x/build/internal/task	75.620s

This may be related to the TestTagXRepos failures reported in #56231 (CC @heschi @dmitshur).

It's not clear to me why watchflakes hadn't filed an issue for this already (CC @cherrymui).
@bcmills bcmills added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Sep 26, 2023
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Sep 26, 2023
@gopherbot gopherbot added this to the Unreleased milestone Sep 26, 2023
@bcmills bcmills added the NeedsFix The path to resolution is known, but the work has not been done. label Sep 26, 2023
@bcmills bcmills self-assigned this Sep 26, 2023
@bcmills bcmills added the Testing An issue that has been verified to require only test changes, not just a test failure. label Sep 26, 2023
@gopherbot gopherbot removed the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Sep 26, 2023
@gopherbot
Copy link

Change https://go.dev/cl/530737 mentions this issue: internal/task: check the error from Git.Clone in FakeCloudBuild.RunScript

@gopherbot
Copy link

Found new dashboard test flakes for:

#!watchflakes
post <- log ~ `panic: runtime error: invalid memory address or nil pointer dereference` && log ~ `^\s*golang.org/x/build/internal/task\.\(\*FakeCloudBuild\)\.RunScript`
2023-09-22 18:56 darwin-amd64-12_0 build@40ab14c3 go@fc57cc31 x/build/internal/task (log) 
panic: runtime error: invalid memory address or nil pointer dereference
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x8 pc=0x19ec94e]

goroutine 495 [running]:
golang.org/x/build/internal/task.(*GitDir).Close(0x19ec32e?)
	/tmp/buildlet/gopath/src/golang.org/x/build/internal/task/git.go:92 +0xe
panic({0x1b211e0?, 0x2649c70?})
	/tmp/buildlet/go/src/runtime/panic.go:914 +0x21f
golang.org/x/build/internal/task.(*FakeCloudBuild).RunScript(0xc0002a41e0, {0x1f2a010, 0xc000094c60}, {0xc00018c600, 0xa1}, {0xc000137cb8?, 0xc000305710?}, {0xc00065a9c0, 0x4, 0x4})
	/tmp/buildlet/gopath/src/golang.org/x/build/internal/task/fakes.go:802 +0x13a
golang.org/x/build/internal/task.(*TagXReposTasks).UpdateGoMod(0xc00065a540, 0xc0006cad78?, {{0xc000137cb8, 0x5}, {0xc0005656c8, 0x12}, {0xc000143ec0, 0x3, 0x4}, {0xc000137d20, ...}, ...}, ...)
	/tmp/buildlet/gopath/src/golang.org/x/build/internal/task/tagx.go:412 +0x9b2
reflect.Value.call({0x1b3eba0?, 0xc0004cf030?, 0x1cb5d80?}, {0x1cb8291, 0x4}, {0xc000094cc0, 0x4, 0x1017b72?})
	/tmp/buildlet/go/src/reflect/value.go:596 +0xce7
reflect.Value.Call({0x1b3eba0?, 0xc0004cf030?, 0xc000162f90?}, {0xc000094cc0?, 0x1cb5d80?, 0xc000790060?})
	/tmp/buildlet/go/src/reflect/value.go:380 +0xb9
golang.org/x/build/internal/workflow.runTask({0x1f2a3c8?, 0xc0002a4280?}, {0x9b, 0x1, 0xec, 0xec, 0xec, 0xaa, 0x4b, 0xef, ...}, ...)
	/tmp/buildlet/gopath/src/golang.org/x/build/internal/workflow/workflow.go:902 +0x3b6
golang.org/x/build/internal/workflow.(*Workflow).Run.func2()
	/tmp/buildlet/gopath/src/golang.org/x/build/internal/workflow/workflow.go:819 +0xa5
created by golang.org/x/build/internal/workflow.(*Workflow).Run in goroutine 354
	/tmp/buildlet/gopath/src/golang.org/x/build/internal/workflow/workflow.go:819 +0xec7
2023-09-22 19:29 darwin-amd64-12_0 build@433076bf go@bcfaf2f0 x/build/internal/task (log) 
panic: runtime error: invalid memory address or nil pointer dereference
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x8 pc=0x10b61e7b]

goroutine 497 [running]:
golang.org/x/build/internal/task.(*GitDir).Close(...)
	/tmp/buildlet/gopath/src/golang.org/x/build/internal/task/git.go:92
panic({0x10f0e140?, 0x117d2da0?})
	/tmp/buildlet/go/src/runtime/panic.go:765 +0x132
golang.org/x/build/internal/task.(*FakeCloudBuild).RunScript(0xc0007984b0, {0x110b7f58, 0xc00061c2a0}, {0xc000782300, 0xa1}, {0xc000286a16?, 0xc00011b6b0?}, {0xc00031d340, 0x4, 0x4})
	/tmp/buildlet/gopath/src/golang.org/x/build/internal/task/fakes.go:802 +0x13a
golang.org/x/build/internal/task.(*TagXReposTasks).UpdateGoMod(0xc00031cb40, 0x6?, {{0xc000286a16, 0x5}, {0xc000280618, 0x12}, {0xc0004ec660, 0x3, 0x4}, {0xc000286a1c, ...}, ...}, ...)
	/tmp/buildlet/gopath/src/golang.org/x/build/internal/task/tagx.go:412 +0x98d
reflect.Value.call({0x10f2c2e0?, 0xc00028bd60?, 0x110a1ee0?}, {0x10b94c35, 0x4}, {0xc00061c300, 0x4, 0x101774b2?})
	/tmp/buildlet/go/src/reflect/value.go:596 +0xce5
reflect.Value.Call({0x10f2c2e0?, 0xc00028bd60?, 0xc0006aa770?}, {0xc00061c300?, 0x110a1ee0?, 0xc000133e60?})
	/tmp/buildlet/go/src/reflect/value.go:380 +0xb9
golang.org/x/build/internal/workflow.runTask({0x110b8310?, 0xc000798550?}, {0xd0, 0x9d, 0xd4, 0x6f, 0x64, 0x2d, 0x46, 0x30, ...}, ...)
	/tmp/buildlet/gopath/src/golang.org/x/build/internal/workflow/workflow.go:902 +0x3a7
golang.org/x/build/internal/workflow.(*Workflow).Run.func2()
	/tmp/buildlet/gopath/src/golang.org/x/build/internal/workflow/workflow.go:819 +0xa5
created by golang.org/x/build/internal/workflow.(*Workflow).Run in goroutine 289
	/tmp/buildlet/gopath/src/golang.org/x/build/internal/workflow/workflow.go:819 +0xec5
2023-09-25 15:16 darwin-amd64-12_0 build@a832c7fe go@bc9da01e x/build/internal/task (log) 
panic: runtime error: invalid memory address or nil pointer dereference
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x8 pc=0xf503f5b]

goroutine 449 [running]:
golang.org/x/build/internal/task.(*GitDir).Close(...)
	/tmp/buildlet/gopath/src/golang.org/x/build/internal/task/git.go:92
panic({0xf8b0140?, 0x10174da0?})
	/tmp/buildlet/go/src/runtime/panic.go:765 +0x132
golang.org/x/build/internal/task.(*FakeCloudBuild).RunScript(0xc0007a9720, {0xfa59f58, 0xc0006d8f60}, {0xc000010900, 0xa1}, {0xc000128a86?, 0xc00067a220?}, {0xc0004cc480, 0x4, 0x4})
	/tmp/buildlet/gopath/src/golang.org/x/build/internal/task/fakes.go:802 +0x13a
golang.org/x/build/internal/task.(*TagXReposTasks).UpdateGoMod(0xc00029b2c0, 0x6?, {{0xc000128a86, 0x5}, {0xc0006062b8, 0x12}, {0xc000280640, 0x3, 0x4}, {0xc000128a8c, ...}, ...}, ...)
	/tmp/buildlet/gopath/src/golang.org/x/build/internal/task/tagx.go:412 +0x98d
reflect.Value.call({0xf8ce2e0?, 0xc0004bdcb0?, 0xfa43ee0?}, {0xf536d15, 0x4}, {0xc0006d8fc0, 0x4, 0xeb194b2?})
	/tmp/buildlet/go/src/reflect/value.go:596 +0xce5
reflect.Value.Call({0xf8ce2e0?, 0xc0004bdcb0?, 0xc0000516e0?}, {0xc0006d8fc0?, 0xfa43ee0?, 0x0?})
	/tmp/buildlet/go/src/reflect/value.go:380 +0xb9
golang.org/x/build/internal/workflow.runTask({0xfa5a310?, 0xc0007a97c0?}, {0x1, 0xa2, 0xed, 0xa2, 0x25, 0x8d, 0x41, 0x5c, ...}, ...)
	/tmp/buildlet/gopath/src/golang.org/x/build/internal/workflow/workflow.go:902 +0x3a7
golang.org/x/build/internal/workflow.(*Workflow).Run.func2()
	/tmp/buildlet/gopath/src/golang.org/x/build/internal/workflow/workflow.go:819 +0xa5
created by golang.org/x/build/internal/workflow.(*Workflow).Run in goroutine 302
	/tmp/buildlet/gopath/src/golang.org/x/build/internal/workflow/workflow.go:819 +0xec5

— watchflakes

@gopherbot
Copy link

Found new dashboard test flakes for:

#!watchflakes
post <- log ~ `panic: runtime error: invalid memory address or nil pointer dereference` && log ~ `^\s*golang.org/x/build/internal/task\.\(\*FakeCloudBuild\)\.RunScript`
2023-09-25 15:16 darwin-amd64-12_0 build@a832c7fe go@5e9afab7 x/build/internal/task (log) 
panic: runtime error: invalid memory address or nil pointer dereference
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x8 pc=0x830ef5b]

goroutine 480 [running]:
golang.org/x/build/internal/task.(*GitDir).Close(...)
	/tmp/buildlet/gopath/src/golang.org/x/build/internal/task/git.go:92
panic({0x86bb140?, 0x8f7fda0?})
	/tmp/buildlet/go/src/runtime/panic.go:765 +0x132
golang.org/x/build/internal/task.(*FakeCloudBuild).RunScript(0xc0007d23c0, {0x8864f58, 0xc000885c80}, {0xc000330400, 0x60}, {0xc000409a96?, 0xc0000cd460?}, {0xc0002d0e00, 0x2, 0x2})
	/tmp/buildlet/gopath/src/golang.org/x/build/internal/task/fakes.go:802 +0x13a
golang.org/x/build/internal/task.(*TagXReposTasks).UpdateGoMod(0xc000818380, 0x68?, {{0xc000409a96, 0x5}, {0xc0005f6948, 0x12}, {0xc0002cef90, 0x2, 0x2}, {0x0, ...}, ...}, ...)
	/tmp/buildlet/gopath/src/golang.org/x/build/internal/task/tagx.go:412 +0x98d
reflect.Value.call({0x86d92e0?, 0xc0002cf2e0?, 0x884eee0?}, {0x8341d15, 0x4}, {0xc000885ce0, 0x4, 0x79244b2?})
	/tmp/buildlet/go/src/reflect/value.go:596 +0xce5
reflect.Value.Call({0x86d92e0?, 0xc0002cf2e0?, 0xc0005a84c0?}, {0xc000885ce0?, 0x884eee0?, 0x7a3a400?})
	/tmp/buildlet/go/src/reflect/value.go:380 +0xb9
golang.org/x/build/internal/workflow.runTask({0x8865310?, 0xc0007d2460?}, {0x70, 0xf7, 0xf4, 0x43, 0xa1, 0x8a, 0x4f, 0xe, ...}, ...)
	/tmp/buildlet/gopath/src/golang.org/x/build/internal/workflow/workflow.go:902 +0x3a7
golang.org/x/build/internal/workflow.(*Workflow).Run.func2()
	/tmp/buildlet/gopath/src/golang.org/x/build/internal/workflow/workflow.go:819 +0xa5
created by golang.org/x/build/internal/workflow.(*Workflow).Run in goroutine 206
	/tmp/buildlet/gopath/src/golang.org/x/build/internal/workflow/workflow.go:819 +0xec5

— watchflakes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bcmills bcmills

Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
Go Release
Archived in project
Test Flakes
Status: Done
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@bcmills @gopherbot