Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: release version v0.14.0 #63220

Closed
8 tasks done
findleyr opened this issue Sep 25, 2023 · 12 comments
Closed
8 tasks done

x/tools/gopls: release version v0.14.0 #63220

findleyr opened this issue Sep 25, 2023 · 12 comments
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@findleyr
Copy link
Contributor

findleyr commented Sep 25, 2023

This issue tracks progress toward releasing gopls@v0.14.0.

(We're aiming to cut this release near the end of October, but are going to start cutting prereleases earlier than usual.)

  • merge master into gopls-release-branch.0.14
  • update hard-coded version
  • update go.mod/go.sum (remove x/tools replace, update x/tools version)
  • tag gopls/v0.14.0-pre.1
  • update Github milestone
  • write release notes
  • smoke test features
  • tag gopls/v0.14.0
@findleyr findleyr added gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository. labels Sep 25, 2023
@gopherbot gopherbot added this to the Unreleased milestone Sep 25, 2023
@gopherbot
Copy link

Change https://go.dev/cl/530977 mentions this issue: all: update codereview.cfg for gopls-release-branch.0.14

gopherbot pushed a commit to golang/tools that referenced this issue Sep 25, 2023
For golang/go#63220

Change-Id: I066d60ab8d578e64c78fbccc3c664d54024d5c88
Reviewed-on: https://go-review.googlesource.com/c/tools/+/530977
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Robert Findley <rfindley@google.com>
Reviewed-by: Alan Donovan <adonovan@google.com>
@gopherbot
Copy link

Change https://go.dev/cl/531035 mentions this issue: all: merge master (fb7463a) into gopls-release-branch.0.14

gopherbot pushed a commit to golang/tools that referenced this issue Sep 25, 2023
For golang/go#63220

Merge List:

+ 2023-09-25 fb7463a gopls: upgrade x/telemetry to latest

Change-Id: Ifb9a4b403a10b3187ee177e9b4bb06b63fb62f9f
@gopherbot
Copy link

Change https://go.dev/cl/530437 mentions this issue: gopls: update go.mod for v0.14.0-pre.1

gopherbot pushed a commit to golang/tools that referenced this issue Sep 25, 2023
Remove the replace directive and update x/tools.

Also run `go mod tidy -compat=1.18`, which actually removes some sum
entries now that we no longer require 1.16 compatibility.

For golang/go#63220

Change-Id: I6b02a965275e7fc9bd18279831141d5660842c53
Reviewed-on: https://go-review.googlesource.com/c/tools/+/530437
Reviewed-by: Peter Weinberger <pjw@google.com>
Auto-Submit: Robert Findley <rfindley@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
@suzmue suzmue modified the milestones: Unreleased, gopls/v0.14.0 Sep 25, 2023
@gopherbot
Copy link

Change https://go.dev/cl/533155 mentions this issue: all: merge master (ee20ddf) into gopls-release-branch.0.14

gopherbot pushed a commit to golang/tools that referenced this issue Oct 5, 2023
Also add back the replace directive, and tidy.

For golang/go#63220

Conflicts:

- gopls/go.sum

Merge List:

+ 2023-10-05 ee20ddf internal/refactor/inline: permit return conversions in tailcall
+ 2023-10-05 db1d1e0 gopls/internal/lsp: go to definition from embed directive
+ 2023-10-05 2be977e internal/refactor/inline: work around channel type misformatting
+ 2023-10-04 0ba9c84 internal/fuzzy: several improvements for symbol matching
+ 2023-10-04 c2725ad gopls: update x/telemetry dependency
+ 2023-10-03 e8722c0 go/types/internal/play: show types.Selection information
+ 2023-10-03 a819c61 internal/refactor/inline: eliminate unnecessary binding decl
+ 2023-10-03 102b64b internal/refactor/inline: tweak everything-test docs again
+ 2023-10-03 197e2c4 internal/refactor/inline: fix broken tests
+ 2023-10-03 586b21a internal/refactor/inline: elide redundant braces
+ 2023-10-02 ca34416 internal/refactor/inline: fallible constant analysis
+ 2023-10-02 6a38a5f internal/refactor/inline: use default working directory
+ 2023-10-02 c6d331d internal/refactor/inline: don't add same import PkgName twice
+ 2023-10-02 1058109 internal/refactor/inline: don't insert unnecessary parens
+ 2023-10-02 d8e94f2 internal/refactor/inline: fix bug in shadow detection
+ 2023-10-02 0adbf9c gopls/internal/lsp: simplify the telemetry prompt
+ 2023-10-02 2ed4298 go/analysis/analysistest: format golden files before comparing
+ 2023-09-28 451716b internal/refactor/inline: consider "", 0.0, 1.0 duplicable
+ 2023-09-28 792f91f internal/refactor/inline: tweak everything test for cgo
+ 2023-09-28 9416299 internal/refactor/inline: fix pkgname shadowing bug
+ 2023-09-28 4cd12d6 gopls/internal/lsp/fake: don't set a completion budget for tests
+ 2023-09-28 57ecf48 gopls/internal/lsp: hover over embed directives
+ 2023-09-28 6de3448 gopls/internal/lsp/cache: remove snapshot.typeCheckMu
+ 2023-09-27 7f23bc8 gopls/internal/regtest/source/completion: reuse functionCallSnippet in unimported completion
+ 2023-09-27 3d03fbd gopls/internal/lsp: use matcher score in ranking unimported candidates
+ 2023-09-27 7577387 gopls/internal/lsp/source: don't complete to golang.org/toolchain
+ 2023-09-27 4b34fbf internal/refactor/inline: fix bug discard receiver and spread
+ 2023-09-27 6ec9b0f internal/refactor/inline: refine "last ref to caller local"
+ 2023-09-27 08bdfec internal/refactor/inline: split up the big table
+ 2023-09-27 486787e gopls/internal/lsp/source: Add ui.complete.completeFunctionCalls toggle
+ 2023-09-27 9d2d0e8 gopls: set a context deadline after minimal completion results
+ 2023-09-26 169105a internal/refactor/inline: insert conversions during substitution
+ 2023-09-26 b3ada30 internal/refactor/inline: analyze callee effects
+ 2023-09-26 1602103 internal/refactor/inline: skip cgo tests on non-cgo builders
+ 2023-09-26 1c8e684 internal/refactor/inline: sound treatment of named results
+ 2023-09-26 d32f97a internal/refactor/inline: eliminate Callee.BodyIsReturnExpr
+ 2023-09-26 f4abeae go/analysis/passes/directive: use strings.Cut
+ 2023-09-26 c42ed47 internal/refactor/inline: reject attempts to inline in cgo code
+ 2023-09-26 313150a internal/refactor/inline: x++ counts as assignment in escape
+ 2023-09-26 d6f1bb7 internal/refactor/inline: ignore line directives in testing

Change-Id: I97157c76bd781c03aef407b86ac1da209846f99a
@gopherbot
Copy link

Change https://go.dev/cl/533177 mentions this issue: gopls: update go.mod for v0.14.0-pre.1

gopherbot pushed a commit to golang/tools that referenced this issue Oct 5, 2023
Remove the replace directive and update x/tools.

For golang/go#63220

Change-Id: Ibf4114b41f34bc57c724e435e0faf031a082d8d8
Reviewed-on: https://go-review.googlesource.com/c/tools/+/533177
Reviewed-by: Alan Donovan <adonovan@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
@gopherbot
Copy link

Change https://go.dev/cl/534616 mentions this issue: all: merge master (9b63f3d) into gopls-release-branch.0.14

gopherbot pushed a commit to golang/tools that referenced this issue Oct 11, 2023
Also reinstate the x/tools replace directive.

For golang/go#63220

Conflicts:

- gopls/go.sum

Merge List:

+ 2023-10-11 9b63f3d gopls: upgrade x/telemetry dependency
+ 2023-10-11 f38ff07 internal/refactor/inline: T{} is duplicable for struct/array
+ 2023-10-11 ecbfa88 go/analysis/passes/timeformat: simplify isTimeDotFormat
+ 2023-10-11 187911b internal/refactor/inline: more precise SelectorExpr effects
+ 2023-10-10 dbf6f42 go/analysis/passes/httpmux: add command
+ 2023-10-10 7e7568c go/analysis/passes/httpmux: check for enhanced ServeMux patterns
+ 2023-10-10 b268156 gopls: allow all drive letters in cache/filemap_test.go
+ 2023-10-10 be4e4d6 go/analysis/passes/internal/analysisutil: account for nil Func.Pkg
+ 2023-10-10 0e4fc90 internal/refactor/inline: add missing spread context (return)
+ 2023-10-10 8954aa7 go/types/internal/play: fix slice OOB when *ast.File is selected
+ 2023-10-10 fda3fe3 gopls/internal/lsp: use the correct options for semantic tokens legend
+ 2023-10-10 f6d8589 cmd/compilebench: pass linker flags to prebuild
+ 2023-10-09 5874869 go/analysis/passes/internal/analysisutil: add IsFunctionNamed
+ 2023-10-09 0b06fd8 cmd/gonew: skip Test if exec is unsupported
+ 2023-10-09 f5fd4c9 go/analysis/passes/bools: use astutil.Unparen
+ 2023-10-09 59ac17f go/analysis/passes/internal/analysisutil: remove Unparen
+ 2023-10-08 a3b5082 go/analysis/passes/appends: improve check for append builtin
+ 2023-10-08 395d393 go/analysis/passes/internal/analysisutil: add IsNamedType
+ 2023-10-08 22abcd6 oogo/analysis/passes/bools: remove duplicate functions
+ 2023-10-06 3f4194e go.mod: update golang.org/x dependencies
+ 2023-10-05 1e4ce7c internal/refactor/inline: yet more tweaks to everything test

Change-Id: Iaf86891ab5af9ee05ada507c75234e750633e0ef
@gopherbot
Copy link

Change https://go.dev/cl/534398 mentions this issue: gopls: update go.mod for v0.14.0-pre.3

gopherbot pushed a commit to golang/tools that referenced this issue Oct 11, 2023
Remove the replace directive and update x/tools.

For golang/go#63220

Change-Id: I1dcffde979bf17ee84df7003c0d13d6933072300
Reviewed-on: https://go-review.googlesource.com/c/tools/+/534398
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Robert Findley <rfindley@google.com>
@gopherbot
Copy link

Change https://go.dev/cl/535835 mentions this issue: all: merge master (53e637b) into gopls-release-branch.0.14

gopherbot pushed a commit to golang/tools that referenced this issue Oct 16, 2023
Also add back the replace directive.

For golang/go#63220

Merge List:

+ 2023-10-16 53e637b internal/refactor/inline: improve check for last uses of free vars
+ 2023-10-16 61bb3e9 internal/refactor/inline: less hacky solution for eliding braces
+ 2023-10-16 8a71c39 gopls/internal/lsp/source: abort change signature on overlapping calls
+ 2023-10-16 f744e4b go/ssa: propagate goversions in ssa
+ 2023-10-16 6fcd778 gopls/internal/lsp: add code actions to remove unused parameters
+ 2023-10-16 918e96a internal/refactor/inline: use binding decl with literalization
+ 2023-10-13 12b5dad gopls: deprecate "tempModfile" and "expandWorkspaceToModule" settings
+ 2023-10-12 f85b3f7 internal/refactor/inline: don't treat blanks as decls in declares()
+ 2023-10-12 3484534 internal/refactor/inline: docs for 0.14 release notes
+ 2023-10-11 b9b97d9 go/types/objectpath: remove method sorting

Change-Id: I371204ec58877fcfaa03f7ba663a6b5718b8ecf0
@gopherbot
Copy link

Change https://go.dev/cl/535836 mentions this issue: all: merge master (43c41b5) into gopls-release-branch.0.14

gopherbot pushed a commit to golang/tools that referenced this issue Oct 16, 2023
For golang/go#63220

Merge List:

+ 2023-10-16 43c41b5 internal/refactor/inline: reify implicit return conversions

Change-Id: Ie2beb052f316efb38d52f7a35557f7c580c19da7
@gopherbot
Copy link

Change https://go.dev/cl/535837 mentions this issue: gopls: update go.mod for v0.14.0-pre.4

gopherbot pushed a commit to golang/tools that referenced this issue Oct 16, 2023
Remove the replace directive and update x/tools.

For golang/go#63220

Change-Id: I844a67c69d7f18e7c6c4bf3bcf9ee3e76057daf5
Reviewed-on: https://go-review.googlesource.com/c/tools/+/535837
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Auto-Submit: Robert Findley <rfindley@google.com>
@gopherbot
Copy link

Change https://go.dev/cl/537119 mentions this issue: all: merge master (5ab57de) into gopls-release-branch.0.14

gopherbot pushed a commit to golang/tools that referenced this issue Oct 24, 2023
Also add back the replace directive.

For golang/go#63220

Merge List:

+ 2023-10-24 5ab57de go/packages: ensure that types.Sizes is correct
+ 2023-10-23 02048e6 go/packages: document that types.Sizes may be nil
+ 2023-10-23 5185da1 internal/refactor/inline: avoid redundant import names added by inlining
+ 2023-10-23 6360c0b gopls/internal/lsp/source: find linkname directives without parsing
+ 2023-10-19 71f6a46 cmd/bundle: drop old +build lines
+ 2023-10-19 cdf1b5e cmd/present: drop NaCl reference from docs
+ 2023-10-18 99bbd3c go/callgraph/vta: use core type for struct fields
+ 2023-10-17 8ed1113 go/ssa: add support for range-over-int
+ 2023-10-16 7df9d5f gopls/internal/lsp: fix signature crash on error.Error

Change-Id: I80b8c0040d9e3ec207446d07212ad671f60c4e7d
@gopherbot
Copy link

Change https://go.dev/cl/537375 mentions this issue: gopls: update go.mod for v0.14.0-pre.5

gopherbot pushed a commit to golang/tools that referenced this issue Oct 24, 2023
Remove the replace directive and update x/tools.

For golang/go#63220

Change-Id: Iea9521860c8b8c256dccf38ea3e45425e97a38ae
Reviewed-on: https://go-review.googlesource.com/c/tools/+/537375
Reviewed-by: Alan Donovan <adonovan@google.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Auto-Submit: Robert Findley <rfindley@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Development

No branches or pull requests

3 participants