Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/net/icmp: ICMPv6 checksum test fails on Windows Server 2003 and XP #6320

Closed
mikioh opened this issue Sep 4, 2013 · 11 comments
Closed

x/net/icmp: ICMPv6 checksum test fails on Windows Server 2003 and XP #6320

mikioh opened this issue Sep 4, 2013 · 11 comments
Labels
FrozenDueToAge help wanted Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Unplanned

Comments

@mikioh
Copy link
Contributor

mikioh commented Sep 4, 2013 

because of http://support.microsoft.com/kb/947369.
thank you for the notice, Tego Lee.
@mikioh
Copy link
Contributor Author

mikioh commented Sep 10, 2013

Comment 1:

Status changed to Started.

@rsc
Copy link
Contributor

rsc commented Sep 10, 2013

Comment 2:

Labels changed: added testing.

@rsc
Copy link
Contributor

rsc commented Sep 11, 2013

Comment 3:

Labels changed: added go1.2maybe, removed go1.2.

@mikioh
Copy link
Contributor Author

mikioh commented Sep 12, 2013

Comment 4:

https://golang.org/cl/13468046/

@mikioh
Copy link
Contributor Author

mikioh commented Sep 13, 2013

Comment 5:

Just a guess what happens w/o CL 13468046 on such editions of Windows.
- go test -short fails
- specifically TestConnICMPEcho, TestPacketConnICMPEcho with "ip6:ipv6-icmp" fails with
"read i/o timeout" or "test timed out after NNN secs"

@mikioh
Copy link
Contributor Author

mikioh commented Sep 14, 2013

Comment 6:

If there's anyone who owns IPv6-enabled Windows Server 2003 or Windows XP Professional
x64 edition that doesn't contain the hotfix, please try with CL 1346804.

Labels changed: added priority-someday, removed priority-triage, go1.2maybe.

Status changed to HelpWanted.

@rsc
Copy link
Contributor

rsc commented Nov 27, 2013

Comment 7:

Labels changed: added go1.3maybe.

@rsc
Copy link
Contributor

rsc commented Dec 4, 2013

Comment 8:

Labels changed: added release-none, removed go1.3maybe.

@rsc
Copy link
Contributor

rsc commented Dec 4, 2013

Comment 9:

Labels changed: added repo-main.

@mikioh
Copy link
Contributor Author

mikioh commented Mar 4, 2014

Comment 10:

I will close CL 13468046 and add a patch here.
--
net: add IPv6 checksum calculation to test
Some editions of Windows have no support for IPv6 upper layer protocol
checksum calculation and it would cause raw IPv6 test failures. This CL
just supplies a such missing feature that is required for raw IPv6 test
cases.
See http://support.microsoft.com/kb/947369.
--

Attachments:

  1. issue13468046_5001.diff.txt (3599 bytes)

@mikioh mikioh added help wanted priority-someday Testing An issue that has been verified to require only test changes, not just a test failure. labels Mar 4, 2014
@rsc rsc added this to the Unplanned milestone Apr 10, 2015
@mikioh mikioh changed the title net: raw IPv6 tests fail on Windows Server 2003 and XP x/net/icmp: ICMPv6 checksum test fails on Windows Server 2003 and XP May 13, 2016
@mikioh
Copy link
Contributor Author

mikioh commented May 13, 2016

The test was already fixed when the package icmp was introduced into x/net repository, Dec 3 2014.

@mikioh mikioh closed this as completed May 13, 2016
@golang golang locked and limited conversation to collaborators May 13, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge help wanted Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Unplanned
Development

No branches or pull requests
3 participants
@mikioh @rsc @gopherbot