Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

image/png: support interlacing #6293

Closed
gopherbot opened this issue Aug 30, 2013 · 9 comments
Closed

image/png: support interlacing #6293

gopherbot opened this issue Aug 30, 2013 · 9 comments
Labels
FrozenDueToAge

Comments

@gopherbot
Copy link
Contributor

by sinni800:

What steps will reproduce the problem?
If possible, include a link to a program on play.golang.org.
1. http://play.golang.org/p/5lY2fRrLt6
2. Download the attachment png
3. Modify the variable "source" so it points to the png
4. Run

What is the expected output?

Nil error, the image is decoded

What do you see instead?

err: unsupported feature: compression, filter or interlace method

Which compiler are you using (5g, 6g, 8g, gccgo)?

6g, 8g

Which operating system are you using?

Windows, Linux

Which version are you using?  (run 'go version')

Tested on tip and 1.1.2

Please provide any additional information below.

Sorry for the image, being a comic. I will gladly accept an image that has the same
unsupported feature as replacement.

Attachments:

  1. sameshirt.png (20062 bytes)
@gopherbot
Copy link
Contributor Author

Comment 1 by sinni800:

The image is interlaced, so the issue is actually:
Feature request image/png: interlaced images

@robpike
Copy link
Contributor

robpike commented Aug 30, 2013

Comment 2:

Labels changed: added priority-later, removed priority-triage.

Status changed to Accepted.

@rsc
Copy link
Contributor

rsc commented Nov 27, 2013

Comment 3:

Labels changed: added go1.3maybe.

@rsc
Copy link
Contributor

rsc commented Dec 4, 2013

Comment 4:

Labels changed: added release-none, removed go1.3maybe.

@rsc
Copy link
Contributor

rsc commented Dec 4, 2013

Comment 5:

Labels changed: added repo-main.

@gopherbot
Copy link
Contributor Author

Comment 6:

CL https://golang.org/cl/102130044 mentions this issue.

@dsymonds
Copy link
Contributor

Comment 7:

This issue was closed by revision 5c2f01f.

Status changed to Fixed.

@gopherbot
Copy link
Contributor Author

Comment 8 by drew.wells00:

When will this fix find itself into a release?

@ianlancetaylor
Copy link
Member

Comment 9:

The fix will be in the 1.4 release, scheduled to occur on December 1.  You can download
1.4 betas for testing right now, as seen on the golang-dev mailing list.

@golang golang locked and limited conversation to collaborators Jun 25, 2016
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jun 25, 2018
@wheatman
image/png: interlacing support for png.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
b2a5c1d 
Fixes golang#6293.

Image "testdata/benchRGB-interlace.png" was generated by opening "testdata/benchRGB.png" in the editor Gimp and saving it with interlacing enabled.

Benchmark:
BenchmarkDecodeRGB        	     500	   7014194 ns/op	  37.37 MB/s
ok  	pkg/image/png	4.657s

BenchmarkDecodeInterlacing	     100	  10623241 ns/op	  24.68 MB/s
ok  	pkg/image/png	1.339s

LGTM=nigeltao
R=nigeltao, andybons, matrixik
CC=golang-codereviews
https://golang.org/cl/102130044
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jul 9, 2018
@wheatman
image/png: interlacing support for png.
a2af7e0 
Fixes golang#6293.

Image "testdata/benchRGB-interlace.png" was generated by opening "testdata/benchRGB.png" in the editor Gimp and saving it with interlacing enabled.

Benchmark:
BenchmarkDecodeRGB        	     500	   7014194 ns/op	  37.37 MB/s
ok  	pkg/image/png	4.657s

BenchmarkDecodeInterlacing	     100	  10623241 ns/op	  24.68 MB/s
ok  	pkg/image/png	1.339s

LGTM=nigeltao
R=nigeltao, andybons, matrixik
CC=golang-codereviews
https://golang.org/cl/102130044
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@dsymonds @rsc @ianlancetaylor @robpike @gopherbot