Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: TestScript/gotoolchain_path fails if golang.org/dl/go1.21.1 is installed in the user's $PATH [1.21 backport] #62711

Closed
gopherbot opened this issue Sep 18, 2023 · 3 comments
Closed

cmd/go: TestScript/gotoolchain_path fails if golang.org/dl/go1.21.1 is installed in the user's $PATH [1.21 backport] #62711

gopherbot opened this issue Sep 18, 2023 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases GoCommand cmd/go Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.21.2

Comments

@gopherbot
Copy link

@bcmills requested issue #62709 to be considered for backport to the next 1.21 minor release.

@gopherbot, please backport to Go 1.21. This causes spurious test failures, and the fix is test-only.
@gopherbot gopherbot added CherryPickCandidate Used during the release process for point releases GoCommand cmd/go Testing An issue that has been verified to require only test changes, not just a test failure. labels Sep 18, 2023
@gopherbot gopherbot mentioned this issue Sep 18, 2023
Closed
@gopherbot gopherbot added this to the Go1.21.2 milestone Sep 18, 2023
@bcmills bcmills added the CherryPickApproved Used during the release process for point releases label Sep 19, 2023
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Sep 19, 2023
@bcmills
Copy link
Contributor

bcmills commented Sep 19, 2023

Approving, since the fix is test-only and this interferes with being able to run tests locally on the release branch.

@gopherbot
Copy link
Author

Change https://go.dev/cl/529435 mentions this issue: [release-branch.go1.21] cmd/go: in TestScript/gotoolchain_path, remove the user's PATH

gopherbot pushed a commit that referenced this issue Sep 19, 2023
@gopherbot
[release-branch.go1.21] cmd/go: in TestScript/gotoolchain_path, remov…
b64dc5f 
…e the user's PATH

This test checks a behavior of GOTOOLCHAIN when an appropriate
toolchain is found in PATH. That requires it to exclude any suitable
toolchain binaries from the user's $PATH, which may otherwise
interfere.

Fixes #62711.
Updates #62709.

Change-Id: Ie9161e52d33a65be0b5265cb49e9f2bc8473e057
Reviewed-on: https://go-review.googlesource.com/c/go/+/529217
Auto-Submit: Bryan Mills <bcmills@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
(cherry picked from commit 30886b1)
Reviewed-on: https://go-review.googlesource.com/c/go/+/529435
Run-TryBot: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
@gopherbot
Copy link
Author

Closed by merging b64dc5f to release-branch.go1.21.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases GoCommand cmd/go Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.21.2
Development

No branches or pull requests
2 participants
@bcmills @gopherbot