Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/go/packages: TestExternal_NotHandled failing since CL 527675 #62703

Closed
bcmills opened this issue Sep 18, 2023 · 1 comment
Closed

x/tools/go/packages: TestExternal_NotHandled failing since CL 527675 #62703

bcmills opened this issue Sep 18, 2023 · 1 comment
Assignees
@pjweinb
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Soon This needs to be done soon. (regressions, serious bugs, outages) Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@bcmills
Copy link
Contributor

bcmills commented Sep 18, 2023 •
edited

https://build.golang.org/log/84728e6e61edcb1bf4b9614d2458b460b541e637:

--- FAIL: TestExternal_NotHandled (0.00s)
    --- FAIL: TestExternal_NotHandled/GOPATH (0.60s)
        packages_test.go:2680: # golang.org/fake/empty_driver
            golang.org/fake/empty_driver/main.go:5:2: "io/ioutil" imported and not used
            golang.org/fake/empty_driver/main.go:10:2: undefined: io
            
        packages_test.go:2681: exit status 1
    --- FAIL: TestExternal_NotHandled/Modules (0.58s)
        packages_test.go:2680: # golang.org/fake/empty_driver
            empty_driver/main.go:5:2: "io/ioutil" imported and not used
            empty_driver/main.go:10:2: undefined: io
            
        packages_test.go:2681: exit status 1
FAIL
FAIL	golang.org/x/tools/go/packages	56.532s

This is failing across all of the -longtest builders; it appears that something was missed in https://go.dev/cl/527675.

(attn @pjweinb)
@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository. labels Sep 18, 2023
@gopherbot gopherbot added this to the Unreleased milestone Sep 18, 2023
@bcmills bcmills added the Soon This needs to be done soon. (regressions, serious bugs, outages) label Sep 18, 2023
@bcmills bcmills mentioned this issue Sep 18, 2023
Open
@pjweinb
Copy link

pjweinb commented Sep 19, 2023

fixed by https://go-review.git.corp.google.com/c/tools/+/529298

@pjweinb pjweinb closed this as completed Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pjweinb pjweinb

Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Soon This needs to be done soon. (regressions, serious bugs, outages) Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@bcmills @pjweinb @gopherbot